[ERP-2645] Add 'resources' config item #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikuPAN
reviewed
Oct 11, 2024
src/components/tool/guide/Config.js
Outdated
| @@ -86,9 +89,23 @@ export const getCpuModel = (config, onChange) => () => { | |||
|
|
|||
| let alertMsg; | |||
| if (config?.cpuModel === "E7-8890v4") { | |||
| alertMsg = "The E7-8890v4 CPU should only be used for large memory jobs."; | |||
| alertMsg = | |||
| "The E7-8890v4 CPU should only be used for jobs with more than 512 GB of ram."; | |||
There was a problem hiding this comment.
Just a thought: replacing with by require sounds more appropriate? Also should ram be capitals? It's abbreviation sames as CPU.
NikuPAN
reviewed
Oct 11, 2024
| inputProps={{ | ||
| choices: [ | ||
| ["Automatic", "Run the job without specifying resources"], | ||
| ["Custom", "Specify the resources to use for the job"], |
There was a problem hiding this comment.
Just a thought: Is to use necessary? I think Specify the resources for the job (manually) would be sufficient?
There was a problem hiding this comment.
Clarified the wording
NikuPAN
approved these changes
Oct 11, 2024
ScriptSmith
force-pushed
the
ERFP-2645-custom-resources
branch
from
984d710 to
1b99b1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.