Skip to content

[ERP-2283] Re-order interactive and batch options #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2024
Merged

[ERP-2283] Re-order interactive and batch options #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/tool/guide/EresearchJob/EresearchJob.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ const getConfigGroups = (config, onConfigChange = () => {}) => {
},
jobType: () => {
const jobTypes = [
["Interactive", "Run the job in an interactive shell"],
["Batch", "Submit the job to the queue to run in the background"],
["Interactive", "Run the job in an interactive shell"],
];
return {
element: (key, selected) => (
Expand Down
30 changes: 15 additions & 15 deletions src/components/tool/guide/EresearchJob/EresearchJob.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,20 @@ export const NoHeader = {
},
};

export const LyraBatch = {
args: {
initialConfig: {
...DEFAULT_CONFIG,
service: "Lyra",
jobType: "Batch",
hardware: "CPU",
cpuVendor: "Any",
cpuCores: 4,
ram: 16,
},
},
};

export const LyraInteractive = {
args: {
initialConfig: {
Expand All @@ -35,7 +49,7 @@ export const LyraCustomHardware = {
initialConfig: {
...DEFAULT_CONFIG,
service: "Lyra",
jobType: "Interactive",
jobType: "Batch",
hardware: "GPU",
cpuVendor: "Intel",
cpuModel: "8260",
Expand All @@ -48,20 +62,6 @@ export const LyraCustomHardware = {
},
};

export const LyraBatch = {
args: {
initialConfig: {
...DEFAULT_CONFIG,
service: "Lyra",
jobType: "Batch",
hardware: "CPU",
cpuVendor: "Any",
cpuCores: 4,
ram: 16,
},
},
};

export const LyraMultiNode = {
args: {
initialConfig: {
Expand Down
Loading