fix: make dialog responsive #712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
components - Make dialog title responsive - Make dialog custom content scrollable - Make action buttons wrap when necessary - Avoid clipping of button content in dialog action buttons chronicles - Wrap buttons in button screen Closes #711
🦋 Changeset detectedLatest commit: d069be9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
HaakonSvane
previously approved these changes
Jan 29, 2025
|
Quick update. Tested on web by resizing browser window and scale and it seems the dialog extends the browser boundaries and is not scrollable. See video Screen.Recording.2025-01-29.at.09.45.36.mov |
|
@HaakonSvane Previous issues should now be fixed 🤞 |
HaakonSvane
approved these changes
Jan 30, 2025
dansvend
deleted the
711-dialog-does-not-show-all-content-when-using-large-text-size
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Components
Chronicles
Closes #711