Skip to content

Conversation

HaakonSvane
Copy link
Collaborator

  • switch internal Progress component workings to sub-dir structure and context for passing information
  • remove title prop on Progress
  • adjust description on Progress.Item to accept either a string or a method that takes in relevant arguments
  • remove internal console error on failed tasks
  • rework the Progress Screen in MAD Chronicles
  • update UI of the Progress and Progress Item components

closes #679

@HaakonSvane HaakonSvane linked an issue Nov 13, 2024 that may be closed by this pull request
@changeset-bot
Copy link

changeset-bot bot commented Nov 13, 2024

🦋 Changeset detected

Latest commit: cc8d463

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@equinor/mad-components Minor
@equinor/mad-chronicles Patch
@equinor/mad-auth Patch
@equinor/mad-core Patch
@equinor/mad-dfw Patch
@equinor/react-native-mad-tag-ocr Patch
@equinor/react-native-skia-draw Patch
@equinor/mad-toast Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Jonas-Omdal
Copy link
Contributor

Minor thing:
Pressing the simulation buttons in the upload simulator affects the progress item above.

Image

@Jonas-Omdal
Copy link
Contributor

The CircularProgress is bigger in size compared to the other status icons. Is this intended?

@Jonas-Omdal
Copy link
Contributor

Jonas-Omdal commented Nov 19, 2024

image
A bit cramped between the "show more" button and the description on smaler devices

@Jonas-Omdal
Copy link
Contributor

image

The "Show more" button is not aligned with the title. Also, would it be better if the description reached the end of the show more button?

@Jonas-Omdal
Copy link
Contributor

Tested on web, iPhone, and iPad. Found a few visual issues, but the code looks clean and well implemented! ✨😎

@HaakonSvane
Copy link
Collaborator Author

@Jonas-Omdal I fixed the alignment issue and the spacing between the show more button and the description on smaller devices.

Regarding the size of the indicator, these have the same size in terms of total space, but are slightly different in apparent height since the circular progress stretches out completely in its container while the icons have some padding applied to them from the icon library. If I change these, the UI would stutter a little bit when they change since the total size of the icon would change based on its content. I suggest we keep it like this to avoid this, but I am open to change it if you don't like it.

The issue regarding the failed task opening again when pressing the simulator button is something I believe has existed before this PR as well, its just that we have never shown a failed progress item with tasks on the screen like this before. I think it has to do with the logic that determines that the task should open. I can fix it as part of this PR if you see it fit, or we can create a new issue. Completely up to you 💯

@Jonas-Omdal
Copy link
Contributor

@Jonas-Omdal I fixed the alignment issue and the spacing between the show more button and the description on smaller devices.

Regarding the size of the indicator, these have the same size in terms of total space, but are slightly different in apparent height since the circular progress stretches out completely in its container while the icons have some padding applied to them from the icon library. If I change these, the UI would stutter a little bit when they change since the total size of the icon would change based on its content. I suggest we keep it like this to avoid this, but I am open to change it if you don't like it.

The issue regarding the failed task opening again when pressing the simulator button is something I believe has existed before this PR as well, its just that we have never shown a failed progress item with tasks on the screen like this before. I think it has to do with the logic that determines that the task should open. I can fix it as part of this PR if you see it fit, or we can create a new issue. Completely up to you 💯

Nice! Let’s keep the indicator size as it is 😁 The layout of the progress screen have been quite adjusted now. There might have been a similar issue like this before, however we now have 3 progress task items. The first progress task is shown is an example of how this component is suppose to look like. This is also shown outside of simulator area. Pressing simulator buttons should not affect this. Would be nice if you could address it in this issue.

@HaakonSvane
Copy link
Collaborator Author

@Jonas-Omdal Will do!

@HaakonSvane
Copy link
Collaborator Author

@Jonas-Omdal Works now

@Jonas-Omdal
Copy link
Contributor

The alignment issue does not seem to be fixed.

Without using the description prop on the Progress.Item it looks fine.

image

But if i add a description it seems like the show more / less button is aligned with the description text instead of the title.

Skjermopptak.2024-11-22.kl.14.09.10.mov

Copy link
Contributor

@Jonas-Omdal Jonas-Omdal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean stuff. Work great now! 😎

@HaakonSvane HaakonSvane merged commit 2a645ec into main Nov 26, 2024
3 checks passed
@HaakonSvane HaakonSvane deleted the 679-modernize-styling-of-progress-component branch November 26, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modernize styling of Progress component

2 participants