-
Notifications
You must be signed in to change notification settings - Fork 3
feat(progress)!: alter visual expression of Progress component #680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(progress)!: alter visual expression of Progress component #680
Conversation
🦋 Changeset detectedLatest commit: cc8d463 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The CircularProgress is bigger in size compared to the other status icons. Is this intended? |
Tested on web, iPhone, and iPad. Found a few visual issues, but the code looks clean and well implemented! ✨😎 |
@Jonas-Omdal I fixed the alignment issue and the spacing between the show more button and the description on smaller devices. Regarding the size of the indicator, these have the same size in terms of total space, but are slightly different in apparent height since the circular progress stretches out completely in its container while the icons have some padding applied to them from the icon library. If I change these, the UI would stutter a little bit when they change since the total size of the icon would change based on its content. I suggest we keep it like this to avoid this, but I am open to change it if you don't like it. The issue regarding the failed task opening again when pressing the simulator button is something I believe has existed before this PR as well, its just that we have never shown a failed progress item with tasks on the screen like this before. I think it has to do with the logic that determines that the task should open. I can fix it as part of this PR if you see it fit, or we can create a new issue. Completely up to you 💯 |
Nice! Let’s keep the indicator size as it is 😁 The layout of the progress screen have been quite adjusted now. There might have been a similar issue like this before, however we now have 3 progress task items. The first progress task is shown is an example of how this component is suppose to look like. This is also shown outside of simulator area. Pressing simulator buttons should not affect this. Would be nice if you could address it in this issue. |
@Jonas-Omdal Will do! |
@Jonas-Omdal Works now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clean stuff. Work great now! 😎
title
prop onProgress
Progress.Item
to accept either a string or a method that takes in relevant argumentscloses #679