Skip to content

Conversation

Jonas-Omdal
Copy link
Contributor

Added fullwidth prop to the button component
Fixes: #164

@Jonas-Omdal Jonas-Omdal requested a review from fnKode November 6, 2024 09:28
@Jonas-Omdal Jonas-Omdal linked an issue Nov 6, 2024 that may be closed by this pull request
@changeset-bot
Copy link

changeset-bot bot commented Nov 6, 2024

🦋 Changeset detected

Latest commit: 11be207

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@equinor/mad-components Minor
@equinor/mad-auth Patch
@equinor/mad-core Patch
@equinor/mad-dfw Patch
@equinor/react-native-mad-tag-ocr Patch
@equinor/react-native-skia-draw Patch
@equinor/mad-toast Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@HaakonSvane
Copy link
Collaborator

Two cents:
Do we need this functionality or can it be achieved in another way? I was hoping that the current style prop on button allowed some way of achieving the same results?

@Jonas-Omdal
Copy link
Contributor Author

Two cents: Do we need this functionality or can it be achieved in another way? I was hoping that the current style prop on button allowed some way of achieving the same results?

Im not sure if it's possible with the current setup for the button. Using the style prop will only affect the container around the Pressable component and not the button content itself. This issue itself is quite old, so not sure how relevant this is now. if you look in description of this issue:

#164

The button in EDS has a prop like this, so i just tried copying that.

@Jonas-Omdal Jonas-Omdal merged commit 49c59fd into main Nov 25, 2024
3 checks passed
@Jonas-Omdal Jonas-Omdal deleted the 164-button-fullwidth-prop branch November 25, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Button: fullWidth prop

2 participants