Skip to content

Avoid assumption of home on isar restart #948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2025
Merged

Avoid assumption of home on isar restart #948

merged 1 commit into from
Oct 21, 2025

Conversation

Eddasol
Copy link
Contributor

@Eddasol Eddasol commented Oct 21, 2025 •
edited
Loading

This will make it possible for the initial state to become available instead of always becoming home on isar restart. It doesn't solve the issues that occur if isar restarts during monitor state, but ending up in intervention needed is better than a falls home-state

Ready for review checklist:

  • A self-review has been performed
  • All commits run individually
  • Temporary changes have been removed, like logging, TODO, etc.
  • The PR has been tested locally
  • A test has been written
    • This change doesn't need a new test
  • Relevant issues are linked
  • Remaining work is documented in issues
    • There is no remaining work from this PR that requires new issues
  • The changes do not introduce dead code as unused imports, functions etc.

@Eddasol Eddasol force-pushed the initial-not-home branch 4 times, most recently from 1f707b4 to fbfac02 Compare October 21, 2025 08:16
@Eddasol Eddasol self-assigned this Oct 21, 2025
@Eddasol Eddasol requested review from andchiind and oysand and removed request for andchiind October 21, 2025 08:36
oysand
oysand approved these changes Oct 21, 2025
View reviewed changes
Copy link
Contributor

@oysand oysand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, remember to update the state diagram since a transition is added

@Eddasol Eddasol merged commit 7989d5c into equinor:main Oct 21, 2025
8 checks passed
@Eddasol Eddasol deleted the initial-not-home branch October 21, 2025 10:57
@Eddasol Eddasol mentioned this pull request Oct 22, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oysand oysand oysand approved these changes

@andchiind andchiind Awaiting requested review from andchiind

Assignees

@Eddasol Eddasol

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Eddasol @oysand