Skip to content

Conversation

haakonsf
Copy link
Contributor

No description provided.

@haakonsf haakonsf marked this pull request as draft October 24, 2024 14:29
@haakonsf haakonsf force-pushed the allow-stopping-from-idle branch from 89a1d09 to 7bf2151 Compare October 29, 2024 09:30
@haakonsf haakonsf marked this pull request as ready for review October 29, 2024 09:48
Copy link
Contributor

@andchiind andchiind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but might want to label this change a breaking change, as it will affect ISAR implementations. We need to make sure they do not crash if they receive the "stop" function call when they don't have a mission running.

@haakonsf
Copy link
Contributor Author

Postponing merging this until isar-taurob test

@haakonsf haakonsf force-pushed the allow-stopping-from-idle branch from 7bf2151 to 7ddfe35 Compare November 20, 2024 13:05
@haakonsf haakonsf merged commit ce0e4e4 into equinor:main Nov 29, 2024
6 checks passed
@haakonsf haakonsf deleted the allow-stopping-from-idle branch November 29, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants