feat(eds-core-react): typography #4125
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d Paragraph components
…es and add new Patterns story
…mport requirement
…n typography components
torleifhalseth
requested review from
Chibuzor-Nwemambu and
millus
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a next-generation typography system for the EDS core React package while deprecating the existing Typography component. The new system provides baseline grid alignment, improved performance, and better semantic HTML structure through specialized components.
Key Changes:
- Introduces three new typography components:
TypographyNext,Heading, andParagraphwith CSS-based styling - Deprecates the existing styled-components-based
Typographycomponent with migration guidance - Migrates test infrastructure from Jest to Vitest across multiple packages
Reviewed Changes
Copilot reviewed 43 out of 44 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/eds-utils/vitest.setup.ts | Adds Vitest test setup configuration |
| packages/eds-utils/vitest.config.ts | Configures Vitest for the utils package |
| packages/eds-utils/src/hooks/useDeprecationWarning.ts | Implements hook for displaying deprecation warnings |
| packages/eds-utils/src/hooks/useDeprecationWarning.test.ts | Tests for the deprecation warning hook |
| packages/eds-core-react/src/components/Typography/Typography.tsx | Adds deprecation warning to existing Typography component |
| packages/eds-core-react/src/components/Typography/Typography.new.tsx | Implements new TypographyNext component with CSS classes |
| packages/eds-core-react/src/components/Typography/Heading.tsx | Implements semantic Heading component (h1-h6) |
| packages/eds-core-react/src/components/Typography/Paragraph.tsx | Implements Paragraph component for body text |
| packages/eds-core-react/src/components/Typography/typography.css | Comprehensive CSS for typography system with baseline grid |
| packages/eds-core-react/src/style.css | Main stylesheet aggregating component styles |
| packages/eds-core-react/rollup.config.js | Adds CSS bundling configuration |
| packages/eds-core-react/package.json | Updates exports to include CSS stylesheet |
| packages/eds-tokens-build/package.json | Updates Vitest version |
| packages/eds-tailwind/package.json | Updates Vite version and export order |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
packages/eds-core-react/src/components/Typography/Typography.stories.shared.tsx
Show resolved
Hide resolved
packages/eds-core-react/src/components/Typography/Typography.stories.shared.tsx
Show resolved
Hide resolved
…Roots in tsconfig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.