feat(eds-data-grid-react): add detail panel to data grid #3898
+229
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magnh
requested review from
Chibuzor-Nwemambu,
millus,
pomfrida,
torleifhalseth and
vnys
as code owners
yusijs
requested changes
Aug 15, 2025
There was a problem hiding this comment.
There are issues with combining this with virtual scroll.
We need to either disable this (or limit the size / expanded count?) when virtualization is turned on, or pass in props to control the row height when expanded by using estimateSize in the virtualizer.
Screenshare.-.2025-08-15.8_57_19.AM.mp4
pomfrida
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
packages/eds-color-palette-generator/scripts/generate-palette-overview.ts
Fixed
Show fixed
Hide fixed
magnh
force-pushed
the
feat/add-detail-panel-to-data-grid
branch
from
67a94d9 to
1c71403
Compare
magnh
force-pushed
the
feat/add-detail-panel-to-data-grid
branch
from
1c71403 to
874031b
Compare
magnh
force-pushed
the
feat/add-detail-panel-to-data-grid
branch
from
870a02b to
f252171
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request change?
This pull request expands the
EdsDataGridprops API by adding arenderDetailPanelprop.This is a suggested implementation of #3896