Skip to content

Add univariate models #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 10, 2025
Merged

Add univariate models #68

merged 10 commits into from
Mar 10, 2025

Conversation

kathsherratt
Copy link
Contributor

Suggestion thanks to @seabbs to add univariate models for each of the explanatory variables, to contrast with the fully adjusted model. This doesn't change existing results, but does really bring out the difference so hopefully helps strengthen the narrative around further work.

Changes:

Model code

  • Add separate univariate models for model structure, country targets, and model. Each just as random effects same as in the full model.
  • Get random effects from all models/targets and save output to dataframe

Figure 2

  • Plot adjusted and unadjusted estimates together

Figure 3

Report

  • Update text to include some numbers for unadjusted estimates in comparison of model structure and country target effects

Proposed figure 2

image

@kathsherratt
Update model-wis.R
5dba0ce 
- Add univariate models for model structure and country targets
- Get effects from all models and output as tibble
- Tidy up code comments
@kathsherratt
Update model-wis.R
a926ca8
@kathsherratt
Update model-plots.R
5044b8d 
- Plot adjusted and unadjusted estimates  together
- Remove showing effects for epidemic trend, as we don't show effects for any of the other (confounding) variables
@kathsherratt
Update random-effects.rds
ded85bf 
Save as single tibble with unadjusted/adjusted effects
@kathsherratt
Update results code
45d4bf7 
Text checked for accuracy but basically unchanged
@kathsherratt
fix fig3 model plot to work with combined random effects df
e3b0dd8 
the models are now not neatly ordered so needs another fix for that.
@kathsherratt
Add univariate fit for each model
d18ff09 
belts and braces, to display differences for each model on fig 3
@kathsherratt
Update model-plots.R
8f33498 
show un/adjusted in fig3 same as fig 2
@kathsherratt
update report
64076ac
@kathsherratt kathsherratt requested a review from sbfnk March 10, 2025 03:10
sbfnk
sbfnk approved these changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@sbfnk sbfnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. My only additional thought is that we might want to do a bit of streamlining of the results presentation - will add a separate issue.

@sbfnk sbfnk merged commit 2f5cafd into main Mar 10, 2025
1 check passed
@sbfnk sbfnk deleted the univariate-models branch March 10, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbfnk sbfnk sbfnk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kathsherratt @sbfnk