Skip to content

Add blogpost/guide on documenting stan #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jul 25, 2025
Merged

Add blogpost/guide on documenting stan #80

merged 13 commits into from
Jul 25, 2025

Conversation

jamesmbaazam
Copy link
Contributor

No description provided.

@jamesmbaazam jamesmbaazam requested review from sbfnk and seabbs March 27, 2025 09:24
@jamesmbaazam
Copy link
Contributor Author

Tagging @seabbs and @sbfnk for early feedback.

seabbs
seabbs reviewed Mar 31, 2025
View reviewed changes
Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks nice so far. I suggest starting with some very clear why and examples

jamesmbaazam
jamesmbaazam commented Apr 3, 2025
View reviewed changes
jamesmbaazam
jamesmbaazam commented Apr 3, 2025
View reviewed changes
jamesmbaazam
jamesmbaazam commented Apr 3, 2025
View reviewed changes
jamesmbaazam
jamesmbaazam commented Apr 3, 2025
View reviewed changes
jamesmbaazam
jamesmbaazam commented Apr 3, 2025
View reviewed changes
jamesmbaazam
jamesmbaazam commented Apr 7, 2025
View reviewed changes
@sbfnk
Copy link
Contributor

sbfnk commented May 16, 2025

There's an error because of an empty doi field. @jamesmbaazam can you change to a string or remove? We'll need to add it post-publication.

jamesmbaazam
jamesmbaazam commented May 19, 2025
View reviewed changes
jamesmbaazam
jamesmbaazam commented May 19, 2025
View reviewed changes
sbfnk
sbfnk approved these changes Jul 25, 2025
View reviewed changes
Copy link
Contributor

@sbfnk sbfnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Sorry it took so long to review in more detail! It's still marked as Draft -- would you consider it ready for merging?

@jamesmbaazam
Copy link
Contributor Author

This looks great. Sorry it took so long to review in more detail! It's still marked as Draft -- would you consider it ready for merging?

Thanks for the review. I will have to take another look since it's been a while so let's keep it as a draft.

jamesmbaazam and others added 3 commits July 25, 2025 16:19
@jamesmbaazam jamesmbaazam marked this pull request as ready for review July 25, 2025 16:03
@jamesmbaazam
Copy link
Contributor Author

@sbfnk I think this can be merged. Thanks for the review and edits.

@sbfnk sbfnk merged commit 2621e2c into main Jul 25, 2025
3 checks passed
@sbfnk sbfnk deleted the stan-doc-guide-blogpost branch July 25, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seabbs seabbs seabbs left review comments

@sbfnk sbfnk sbfnk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jamesmbaazam @sbfnk @seabbs