HomeWork3 - js-1 #9
Conversation
DanilRostov
left a comment
DanilRostov
left a comment
There was a problem hiding this comment.
Good job. Unfortunately 3.js doesn't work at all.
Anatoly Shlom/1.js
Outdated
| splitAndMerge("Hello World!",",") should return "H,e,l,l,o W,o,r,l,d,!" */ | ||
|
|
||
| function splitAndMerge (str, sp) { | ||
| target=str.split(' ').join('').split('').join(sp); |
There was a problem hiding this comment.
Not a good way to declare a variable
There was a problem hiding this comment.
You mean the "target" variable? What would be better way?
| target=str.split(' ').join('').split('').join(sp); | ||
| return target | ||
| } | ||
| console.log(splitAndMerge("Hello there!",",")) |
There was a problem hiding this comment.
Current output is H,e,l,l,o,t,h,e,r,e,! instad of H,e,l,l,o t,h,e,r,e,!
There was a problem hiding this comment.
but... well... it seems to me that i've been confused with this
splitAndMerge("My name is John"," ") should return "M y n a m e i s J o h n"
(no extra spaces here)
am i missing some logic of how function should work?
| }) | ||
| return target.join(''); | ||
| } | ||
| console.log(toCamelCase("the-stealth-warrior")); |
There was a problem hiding this comment.
please try to run this file in Node.js. I get this output
There was a problem hiding this comment.
Fixed. Forgot about arr.splice(n,1);
Anatoly Shlom/10.js
Outdated
| Function.prototype.myBind = function () { | ||
| var target = this; | ||
| var args = arguments[0]; | ||
| curArgs = [].slice.call(arguments, 1); |
There was a problem hiding this comment.
Why you didn't write var or const here?
Anatoly Shlom/10.js
Outdated
| curArgs = [].slice.call(arguments, 1); | ||
| return function() { | ||
| var newArgs = [].slice.call(arguments); | ||
| targetArgs = curArgs.concat(newArgs); |
2 participants
All 10 functions finished - No global vars, no ES6.