Nikita Korzhavin js-1 #4
Conversation
svvald
left a comment
svvald
left a comment
There was a problem hiding this comment.
Very good work in general with a couple of recommendations given
Nikita_Korzhavin/js10myBind.js
Outdated
| @@ -0,0 +1,26 @@ | |||
| Function.prototype.myBind = function(context) { | |||
| if (typeof this !== 'function') { | |||
There was a problem hiding this comment.
It seems that you don't need this check since you are changing the prototype of Function. If you will try to invoke myBind from string, for instance, you'll get TypeError: myBind is not a function
Nikita_Korzhavin/js9countDown.js
Outdated
| @@ -0,0 +1,14 @@ | |||
| function countDown(num) { | |||
| for (var i = num; i >= 0; i--) { | |||
| function time(i) { | |||
There was a problem hiding this comment.
I'd move function declaration outside of for loop
Nikita_Korzhavin/js9countDown.js
Outdated
| }, 1000 * (num - i)); | ||
| } | ||
| var binded = time.bind(null, i); | ||
| binded(i); |
There was a problem hiding this comment.
You could write it like this time.bind(null, i)() or even better time.bind(null)(i) which is called currying.
Although I don't insist on changing it but strongly recommend you to read more about it since it is a part of functional approach and some JS programmers prefer it to imperative nowadays
2 participants
No description provided.