Skip to content

Confirmation before deleting in the Dashboard #13035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 14, 2025

Conversation

somebody1234
Copy link
Contributor

@somebody1234 somebody1234 commented May 6, 2025

Pull Request Description

Important Notes

None

Testing Instructions

  • Just delete any asset in the Cloud via both keyboard (Delete), the context menu, and by dragging to Trash
    • All assets should now show the dialog. Previously only directories did so.
  • Also delete multiple assets usingkeyboard, the context menu and dragging to Trash

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@somebody1234 somebody1234 requested a review from PabloBuchu as a code owner May 6, 2025 09:17
@somebody1234 somebody1234 added the CI: No changelog needed Do not require a changelog entry for this PR. label May 6, 2025
Copy link

github-actions bot commented May 6, 2025

🧪 Storybook is successfully deployed!

📊 Dashboard:

@PabloBuchu
Copy link
Contributor

Shouldnt we also show it when user drag n drops on trash category?

@somebody1234
Copy link
Contributor Author

yeah, will fix soon:tm:

@somebody1234
Copy link
Contributor Author

@PabloBuchu addressed

@somebody1234 somebody1234 added the CI: Ready to merge This PR is eligible for automatic merge label May 14, 2025
@mergify mergify bot merged commit f6ed73d into develop May 14, 2025
61 of 65 checks passed
@mergify mergify bot deleted the wip/sb/always-confirm-deleting-assets branch May 14, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--bug Type: bug CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge g-dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants