Skip to content

Fix Dropdown visuals #13033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 20, 2025
Merged

Conversation

MrFlashAccount
Copy link
Contributor

@MrFlashAccount MrFlashAccount commented May 6, 2025

Pull Request Description

This PR fixes visuals for dropdown component.

This PR doesn't solve ALL issues with dropdown, but improve overall look

New:

CleanShot 2025-05-06 at 10 59 07@2x

Old:

CleanShot 2025-05-06 at 11 01 47@2x

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@MrFlashAccount MrFlashAccount self-assigned this May 6, 2025
@MrFlashAccount MrFlashAccount added CI: No changelog needed Do not require a changelog entry for this PR. g-dashboard labels May 6, 2025
@MrFlashAccount MrFlashAccount added the CI: Ready to merge This PR is eligible for automatic merge label May 13, 2025
@MrFlashAccount MrFlashAccount force-pushed the wip/sergeigarin/fix-dropdown-visuals branch from 431abfe to d2a1fe9 Compare May 20, 2025 13:39
Copy link

github-actions bot commented May 20, 2025

🧪 Storybook is successfully deployed!

📊 Dashboard:

@MrFlashAccount MrFlashAccount merged commit 163c1bc into develop May 20, 2025
63 of 65 checks passed
@MrFlashAccount MrFlashAccount deleted the wip/sergeigarin/fix-dropdown-visuals branch May 20, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge g-dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants