Skip to content

Add cache for tailwind-variants #13018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 6, 2025

Conversation

MrFlashAccount
Copy link
Contributor

Pull Request Description

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

Copy link

github-actions bot commented May 2, 2025

🧪 Storybook is successfully deployed!

📊 Dashboard:

Copy link
Contributor

@somebody1234 somebody1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this XD

(well i can see what it is but am surprised if it's actually faster...)

@MrFlashAccount
Copy link
Contributor Author

@somebody1234, the faster performance is primarily due to the cache being located on the tv() instance. This enables the ‘variants()’ call to be faster by reusing caches from previous calls. Since most of our components are quite similar, caching significantly improves the rendering process, resulting in a 20%-30% speed boost.

@PabloBuchu
Copy link
Contributor

@MrFlashAccount please fill up description and maybe testing scenario as I am not seeing what it is so quickly;)

@MrFlashAccount MrFlashAccount added CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge labels May 6, 2025
@mergify mergify bot merged commit fc313a7 into develop May 6, 2025
64 of 67 checks passed
@mergify mergify bot deleted the wip/sergeigarin/tailwind-variants-cache branch May 6, 2025 09:47
Frizi pushed a commit that referenced this pull request May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants