Editable argument name #13014
Merged
Editable argument name #13014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frizi
requested review from
farmaazon,
vitvakatu,
kazcw,
AdRiley,
PabloBuchu,
indiv0,
somebody1234 and
MrFlashAccount
as code owners
vitvakatu
reviewed
May 1, 2025
app/gui/src/project-view/components/GraphEditor/CodeMirrorWidgetBase.vue
Outdated
Show resolved
Hide resolved
kazcw
reviewed
May 2, 2025
Comment on lines
+55
to
+66
| const allWidgetsComputed = [ | ||
| mkWidget(() => definition.open), | ||
| mkWidget(() => definition.open2), | ||
| mkWidget(() => definition.suspension), | ||
| mkWidget(() => definition.pattern, patternWidget), | ||
| mkWidget(() => definition.type?.operator), | ||
| mkWidget(() => definition.type?.type), | ||
| mkWidget(() => definition.close2), | ||
| mkWidget(() => definition.defaultValue?.equals), | ||
| mkWidget(() => definition.defaultValue?.expression), | ||
| mkWidget(() => definition.close), | ||
| ] |
There was a problem hiding this comment.
We could use argumentDefinitionToConcrete
There was a problem hiding this comment.
There is a special case in the middle, pattern has a different widget kind and soon other parts (type, default value expression) will have different ones as well.
app/gui/src/project-view/components/GraphEditor/widgets/WidgetText.vue
Outdated
Show resolved
Hide resolved
app/gui/src/project-view/providers/widgetRegistry/editHandler.ts
Outdated
Show resolved
Hide resolved
app/gui/src/project-view/components/GraphEditor/CodeMirrorWidgetBase.vue
Outdated
Show resolved
Hide resolved
app/gui/src/project-view/components/GraphEditor/CodeMirrorWidgetBase.vue
Outdated
Show resolved
Hide resolved
🧪 Storybook is successfully deployed!📊 Dashboard:
|
Frizi
added
the
CI: No changelog needed
|
Added "no changelog needed" as a workaround for broken CI changelog check. The changelog entry is present in the PR. |
kazcw
approved these changes
May 12, 2025
Frizi
requested review from
radeusgd,
jdunkerley and
GregoryTravis
as code owners
Frizi
requested review from
marthasharkey,
4e6,
JaroslavTulach,
hubertp and
Akirathan
as code owners
…pdowns to not show up in certain cases
Frizi
force-pushed
the
wip/frizi/editable-argument-name-type
branch
from
5902ea5 to
e17b8b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement editing grouped component argument names.
Fixes #12911
edit-arg-names.mp4
enter.arg-name-validation-error.mp4
Important Notes
Fairly big code changes included:
onUpdatenow returns an update result and can be async. That allows widgets to properly handle error states caused by their attempted updates. Injecting an update processor in the middle of the chain also allows for inesrting additional input validation by intermediate widgets (used by argument name editor to only acceptAst.Exprpatterns).codemirror. Now there is a commonCodeMirrorWidgetBasecomponent that abstracts away most of the complexities of dealing with the editor, while allowing it to still be configurable (e.g. adding extra extensions). Only the final conversion of widget input data into text and emitting the final edit remains a responsibility of individual widgets. This common layer is now used byWidgetText,WidgetFunctionNameandWidgetEnsoExpression, but more widgets with any form of text input can be later ported as needed.widgetPillshared class.