Use Rounding_Mode instead of use_bankers flag
#12641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GregoryTravis
added
the
CI: Clean build required
github-actions
bot
added
-libs-API-change-Database
GregoryTravis
requested review from
jdunkerley,
radeusgd,
AdRiley and
marthasharkey
as code owners
GregoryTravis
added
the
CI: Ready to merge
somebody1234
removed request for
indiv0,
Frizi,
kazcw,
PabloBuchu,
farmaazon,
somebody1234,
vitvakatu and
MrFlashAccount
| @@ -47,7 +47,7 @@ | |||
| - floor self -> Standard.Base.Data.Numbers.Integer | |||
| - negate self -> Standard.Base.Data.Numbers.Integer | |||
| - parse text:Standard.Base.Data.Text.Text radix:Standard.Base.Data.Numbers.Integer= -> Standard.Base.Any.Any | |||
| - round self decimal_places:Standard.Base.Data.Numbers.Integer= rounding_mode:Standard.Base.Data.Numeric.Rounding_Mode.Rounding_Mode= -> Standard.Base.Any.Any | |||
| - round self decimal_places:Standard.Base.Data.Numbers.Integer= rounding_mode:(Standard.Base.Data.Numeric.Rounding_Mode.Rounding_Mode|Standard.Base.Data.Boolean.Boolean)= -> Standard.Base.Any.Any | |||
There was a problem hiding this comment.
- Why there is no return type specification?
- at least I guess missing
-> Numberis the reason why the return type isAny - specifying more narrow return type should help static analysis
| @@ -3,4 +3,4 @@ | |||
| - type Rounding_Mode | |||
| - Bankers | |||
| - Half_Up | |||
| - to_java_rounding_mode self -> Standard.Base.Data.Numeric.Rounding_Mode.RoundingMode | |||
| - resolve_deprecated_rounding_mode type_name:Standard.Base.Data.Text.Text rounding_mode:(Standard.Base.Data.Numeric.Rounding_Mode.Rounding_Mode|Standard.Base.Data.Boolean.Boolean) ~action:Standard.Base.Any.Any -> Standard.Base.Any.Any | |||
There was a problem hiding this comment.
Why is this function visible to public at all?
There was a problem hiding this comment.
This is removed now.
| ## PRIVATE | ||
| Convert deprecated `use_bankers : Boolean` arguments (passed as | ||
| `rounding_mode`) to `Rounding_Mode`. | ||
| resolve_deprecated_rounding_mode (type_name:Text) (rounding_mode : Rounding_Mode | Boolean) ~action = |
There was a problem hiding this comment.
Suggested change
| resolve_deprecated_rounding_mode (type_name:Text) (rounding_mode : Rounding_Mode | Boolean) ~action = | |
| private resolve_deprecated_rounding_mode (type_name:Text) (rounding_mode : Rounding_Mode | Boolean) ~action = |
GregoryTravis
removed
the
CI: Ready to merge
GregoryTravis
added
the
CI: Ready to merge
| @@ -1,3 +1,6 @@ | |||
| from Standard.Base import all | |||
There was a problem hiding this comment.
- This is too wide import, @GregoryTravis
- usually explicit
import project.are used to import modules from the same project - causes problems for PoC: Getting
Any,Text& numbers closure down to 35 modules #12819 - can you replace it with explicit imports?
farmaazon
pushed a commit
that referenced
this pull request
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the
use_bankersflag with the more flexible and user-friendlyRounding_Modevalue. This will allow additional rounding modes to be added in the future, rather than adding additional argument flags for each feature.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.