Skip to content

Commit 7093564

Browse files
authored
Use Missing_Value for more arguments on Table (#13012)
Fixes bugs when widgets and values are not displaying (e.g. using type in column selector). - ✅ rename_columns: `column_map` remove default rename of first columng to "Column" and added missing value. - ✅ set: added to `value` - had no default previously. - ✅ sort: require user to specify the `column` to sort on as opposed to defaulting to the first column. - ✅ format: added to `columns` - had no default previously. - ✅ cast: added to `columns`, no longer defaults to first column, and `value_type`, had no default previously. - ✅ split_to_columns: added to `column` - had no default previously, removed default `delimiter` and replaced with missing value. - ✅ split_to_rows: added to `column` - had no default previously, removed default `delimiter` and replaced with missing value. - ✅ tokenize_to_columns: added to `column` - had no default previously, and changed default pattern from `.` to missing value. - ✅ tokenize_to_rows: added to `column` - had no default previously, and changed default pattern from `.` to missing value. - ✅ parse_to_columns: added to `column` - had no default previously, and changed default pattern from `.` to missing value. - ✅ expand_column: added to `column` - had no default previously. - ✅ expand_to_rows: added to `column` - had no default previously. - ✅ replace: added to `lookup_table` - had no default previously. - ✅ union: added to `tables` - had no default previously. - ✅ cross_tab: changed `names` from first column to missing value. - ✅ write: added to `path` - had no default previously.
1 parent ae1a00e commit 7093564

33 files changed

+164
-138
lines changed

distribution/lib/Standard/Base/0.0.0-dev/src/Data/Array.enso

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -441,6 +441,8 @@ type Array
441441
Array_Like_Helpers.flat_map self function on_problems
442442

443443
## ALIAS where
444+
GROUP Selections
445+
ICON preparation
444446
MACRO equals filter=..Equal
445447
MACRO not_equals filter=..Not_Equal
446448
MACRO not_nothing filter=..Not_Nothing
@@ -455,8 +457,6 @@ type Array
455457
MACRO like filter=..Like
456458
MACRO regex_match filter=..Regex_Match
457459
MACRO predicate filter=v->v==Nothing
458-
GROUP Selections
459-
ICON preparation
460460
Selects all elements of this array which satisfy a condition.
461461

462462
Arguments:

distribution/lib/Standard/Base/0.0.0-dev/src/Data/Json/Extensions.enso

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ import project.Errors.Deprecated.Deprecated
1717
import project.Errors.Illegal_Argument.Illegal_Argument
1818
import project.Meta
1919
import project.Nothing.Nothing
20-
import project.Warning.Warning
2120
import project.Runtime.Source_Location.Source_Location
21+
import project.Warning.Warning
2222
from project.Data.Boolean import Boolean, False, True
2323
from project.Data.Range.Extensions import all
2424
from project.Data.Text.Extensions import all
@@ -197,6 +197,9 @@ Text.parse_fast_json self =
197197
warning = Deprecated.Warning "Standard.Base.Data.Text.Text" "parse_fast_json" "Deprecated: The `parse_json` method uses a faster implementation now by default"
198198
Warning.attach warning self.parse_json
199199

200+
## PRIVATE
201+
ICON convert
202+
Extension for Source_Location to allow use.
200203
Source_Location.to_js_object self =
201204
pairs = Vector.build initial_capacity=5 b->
202205
b.append ["type", "Source_Location"]

distribution/lib/Standard/Base/0.0.0-dev/src/Data/List.enso

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -263,6 +263,8 @@ type List
263263
not_empty self = self.is_empty.not
264264

265265
## ALIAS where
266+
GROUP Selections
267+
ICON preparation
266268
MACRO equals filter=..Equal
267269
MACRO not_equals filter=..Not_Equal
268270
MACRO not_nothing filter=..Not_Nothing
@@ -277,8 +279,6 @@ type List
277279
MACRO like filter=..Like
278280
MACRO regex_match filter=..Regex_Match
279281
MACRO predicate filter=v->v==Nothing
280-
GROUP Selections
281-
ICON preparation
282282
Selects all elements of this list which satisfy a condition.
283283

284284
Arguments:

distribution/lib/Standard/Base/0.0.0-dev/src/Data/Range.enso

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -185,6 +185,8 @@ type Range
185185
Vector.new self.length (i -> function (self.start + i*self.step))
186186

187187
## ALIAS where
188+
GROUP Selections
189+
ICON preparation
188190
MACRO equals filter=..Equal
189191
MACRO not_equals filter=..Not_Equal
190192
MACRO not_nothing filter=..Not_Nothing
@@ -199,8 +201,6 @@ type Range
199201
MACRO like filter=..Like
200202
MACRO regex_match filter=..Regex_Match
201203
MACRO predicate filter=v->v==Nothing
202-
GROUP Selections
203-
ICON preparation
204204
Returns a vector of all elements of this range which satisfy a condition.
205205

206206
Arguments:

distribution/lib/Standard/Base/0.0.0-dev/src/Data/Vector.enso

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -539,6 +539,8 @@ type Vector a
539539
not_empty self = self.is_empty.not
540540

541541
## ALIAS where
542+
GROUP Selections
543+
ICON preparation
542544
MACRO equals filter=..Equal
543545
MACRO not_equals filter=..Not_Equal
544546
MACRO not_nothing filter=..Not_Nothing
@@ -553,8 +555,6 @@ type Vector a
553555
MACRO like filter=..Like
554556
MACRO regex_match filter=..Regex_Match
555557
MACRO predicate filter=v->v==Nothing
556-
GROUP Selections
557-
ICON preparation
558558
Selects all elements of this vector which satisfy a condition.
559559

560560
Arguments:

distribution/lib/Standard/Base/0.0.0-dev/src/Logging.enso

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@ import project.Any.Any
22
import project.Data.Numbers.Integer
33
import project.Data.Text.Text
44
import project.Data.Vector.Vector
5+
import project.Internal.Meta_Helpers
56
import project.Meta
67
import project.Nothing.Nothing
7-
import project.Internal.Meta_Helpers
88

99
polyglot java import org.slf4j.LoggerFactory
1010

distribution/lib/Standard/Base/0.0.0-dev/src/Meta.enso

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ type Type
2828
Returns a vector of `Meta.Constructor` instances for this type.
2929
Only publicly visible constructors are returned. A type with no
3030
public constructors returns `[]`.
31-
3231
constructors self -> Vector Constructor =
3332
Meta_Helpers.get_type_constructors_builtin self.value Meta.Constructor.Value
3433

@@ -107,7 +106,6 @@ type Atom
107106
Returns a vector of field values of the given atom.
108107
Only values of public fields are returned. Should an atom
109108
have no public fields, then `[]` is returned.
110-
111109
fields self -> Vector Any = Meta_Helpers.get_atom_fields_builtin self.value
112110

113111
## ADVANCED
@@ -116,7 +114,6 @@ type Atom
116114
Returns a constructor value of the given atom. If the atom
117115
doesn't have a public constructor, then `Private_Access` error
118116
is returned.
119-
120117
constructor self -> Constructor ! Private_Access =
121118
c = Meta_Helpers.get_atom_constructor_builtin self.impl ...
122119
Meta.Constructor.Value c...

0 commit comments

Comments
 (0)