Add separate steps for linting rust and libraries (#13043)

- close #12086

Author: 4e6

.github/workflows/engine-checks-nightly.yml

@@ -349,6 +349,8 @@ jobs:
         run: ./run git-clean
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      - name: Check syntax
+        run: ./run libraries check-syntax
       - run: rm -rf built-distribution test
         shell: bash
       - name: Download Engine Distribution

.github/workflows/engine-checks.yml

@@ -174,6 +174,8 @@ jobs:
         run: ./run git-clean
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      - name: Check syntax
+        run: ./run libraries check-syntax
       - run: rm -rf built-distribution test
         shell: bash
       - name: Download Engine Distribution

.github/workflows/wasm-checks.yml

@@ -15,8 +15,8 @@ concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}-wasm-checks
   cancel-in-progress: ${{ github.ref != 'refs/heads/develop' }}
 jobs:
-  enso-build-ci-gen-job-lint-linux-amd64:
-    name: Lint (linux, amd64)
+  enso-build-ci-gen-job-native-test-linux-amd64:
+    name: Native Rust tests (linux, amd64)
     runs-on:
       - self-hosted
       - Linux
@@ -54,16 +54,16 @@ jobs:
         run: ./run git-clean
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-      - run: ./run lint
+      - run: ./run wasm test --no-wasm
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       - if: "(always()) && (contains(github.event.pull_request.labels.*.name, 'CI: Clean build required') || (github.ref == 'refs/heads/develop') || inputs.clean_build_required)"
         name: Clean after
         run: ./run git-clean
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-  enso-build-ci-gen-job-native-test-linux-amd64:
-    name: Native Rust tests (linux, amd64)
+  enso-build-ci-gen-job-wasm-lint-linux-amd64:
+    name: Lint (linux, amd64)
     runs-on:
       - self-hosted
       - Linux
@@ -101,7 +101,7 @@ jobs:
         run: ./run git-clean
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-      - run: ./run wasm test --no-wasm
+      - run: ./run wasm lint
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       - if: "(always()) && (contains(github.event.pull_request.labels.*.name, 'CI: Clean build required') || (github.ref == 'refs/heads/develop') || inputs.clean_build_required)"

build_tools/build/src/ci_gen.rs

@@ -844,7 +844,7 @@ pub fn wasm_checks() -> Result<Workflow> {
         on,
         ..default()
     };
-    workflow.add(PRIMARY_TARGET, job::Lint);
+    workflow.add(PRIMARY_TARGET, job::WasmLint);
     workflow.add(PRIMARY_TARGET, job::WasmTest);
     workflow.add(PRIMARY_TARGET, job::NativeTest);
     Ok(workflow)

build_tools/build/src/ci_gen/job.rs

@@ -405,13 +405,20 @@ impl JobArchetype for EnsoCodeLintCheck {
         let engine_launcher = self.engine_launcher;
         let mut job = RunStepsBuilder::new("libraries lint")
             .customize(move |step| {
+                let check_syntax = Step {
+                    name: Some("Check syntax".into()),
+                    run: Some("./run libraries check-syntax".into()),
+                    ..Default::default()
+                };
+
                 let cleanup_engine_distribution =
                     step::cleanup_engine_distribution(engine_launcher);
 
                 let download_engine_distribution =
                     step::download_engine_distribution(target, engine_launcher, graal_edition);
 
                 vec![
+                    check_syntax,
                     cleanup_engine_distribution,
                     download_engine_distribution,
                     step::unpack_engine_distribution(),
@@ -646,11 +653,11 @@ impl JobArchetype for SnowflakeTests {
 }
 
 #[derive(Clone, Copy, Debug)]
-pub struct Lint;
+pub struct WasmLint;
 
-impl JobArchetype for Lint {
+impl JobArchetype for WasmLint {
     fn job(&self, target: Target) -> Job {
-        plain_job(target, "Lint", "lint")
+        plain_job(target, "Lint", "wasm lint")
     }
 }
 

build_tools/build/src/rust/enso_linter.rs

@@ -31,7 +31,7 @@ fn collect_source_paths(repo_root: &RepoRoot) -> Result<Vec<PathBuf>> {
     Ok(glob_paths.into_iter().flatten().collect::<std::result::Result<_, _>>()?)
 }
 
-pub async fn lint_all(repo_root: RepoRoot) -> Result<()> {
+pub async fn check_syntax(repo_root: RepoRoot) -> Result<()> {
     let sources = collect_source_paths(&repo_root)?;
     cargo_run_linter_cmd(&repo_root)?.arg("--").args(sources).run_ok().await?;
     Ok(())

build_tools/cli/src/arg.rs

@@ -127,8 +127,6 @@ pub enum Target {
     /// Clean the repository. Keeps the IntelliJ's .idea directory intact. WARNING: This removes
     /// files that are not under version control in the repository subtree.
     GitClean(git_clean::Options),
-    /// Lint non-TypeScript codebase. TypeScript Linting is part of the GUI Check target.
-    Lint,
     /// Apply automatic formatters on the repository.
     #[clap(alias = "format")]
     Fmt,

build_tools/cli/src/arg/libraries.rs

@@ -7,6 +7,8 @@ use clap::Subcommand;
 
 #[derive(Subcommand, Clone, Copy, Debug, PartialEq, Eq)]
 pub enum Command {
+    /// Run enso parser on Enso source files.
+    CheckSyntax,
     /// Run a linter on Enso source files.
     Lint,
 }

build_tools/cli/src/arg/wasm.rs

@@ -24,6 +24,7 @@ pub enum Command {
         #[clap(long, enso_env(), value_enum, default_values_t = [Browser::Firefox])]
         browser:   Vec<Browser>,
     },
+    Lint,
 }
 
 #[derive(Args, Clone, Debug)]

build_tools/cli/src/lib.rs

@@ -278,6 +278,32 @@ impl Processor {
                 let root = self.repo_root.to_path_buf();
                 async move { project::wasm::test(root, &wasm_browsers, !no_native).await }.boxed()
             }
+            arg::wasm::Command::Lint => {
+                let repo_root = self.repo_root.clone();
+                async move {
+                    Cargo
+                        .cmd()?
+                        .current_dir(&repo_root)
+                        .arg(cargo::clippy::COMMAND)
+                        .apply(&cargo::Options::Workspace)
+                        .apply(&cargo::Options::Package("enso-integration-test".into()))
+                        .apply(&cargo::Options::AllTargets)
+                        .apply(&cargo::Color::Always)
+                        .arg("--")
+                        .apply(&rustc::Option::Deny(rustc::Lint::Warnings))
+                        .run_ok()
+                        .await?;
+
+                    Cargo
+                        .cmd()?
+                        .current_dir(&repo_root)
+                        .arg("fmt")
+                        .args(["--", "--check"])
+                        .run_ok()
+                        .await
+                }
+                .boxed()
+            }
         }
     }
 
@@ -737,30 +763,6 @@ pub async fn main_internal(config: Option<Config>) -> Result {
             };
             try_join(git_clean, clean_cache).await?;
         }
-        Target::Lint => {
-            Cargo
-                .cmd()?
-                .current_dir(&ctx.repo_root)
-                .arg(cargo::clippy::COMMAND)
-                .apply(&cargo::Options::Workspace)
-                .apply(&cargo::Options::Package("enso-integration-test".into()))
-                .apply(&cargo::Options::AllTargets)
-                .apply(&cargo::Color::Always)
-                .arg("--")
-                .apply(&rustc::Option::Deny(rustc::Lint::Warnings))
-                .run_ok()
-                .await?;
-
-            Cargo
-                .cmd()?
-                .current_dir(&ctx.repo_root)
-                .arg("fmt")
-                .args(["--", "--check"])
-                .run_ok()
-                .await?;
-
-            enso_build::rust::enso_linter::lint_all(ctx.repo_root.clone()).await?;
-        }
         Target::Fmt => {
             enso_build::web::install(&ctx.repo_root).await?;
             let prettier =
@@ -839,6 +841,9 @@ pub async fn main_internal(config: Option<Config>) -> Result {
             enso_build::changelog::check::check(ctx.repo_root.clone(), ci_context).await?;
         }
         Target::Libraries(command) => match command.action {
+            libraries::Command::CheckSyntax => {
+                enso_build::rust::enso_linter::check_syntax(ctx.repo_root.clone()).await?;
+            }
             libraries::Command::Lint => {
                 let config = enso_build::engine::BuildConfigurationFlags {
                     run_enso_lint: true,