-
Notifications
You must be signed in to change notification settings - Fork 16
Add tests #162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
So the devnet now registers those names right? this isn't only for tests |
Isn't devnet by definition for test? The script already existed. I only added bunch of other names mimicking various transactions. |
Wasn't aware that devnet is used for tests as well. Thought it's for integration testing for the front-end mostly |
oh, you meant for automated test? I checked if example.eth, etc are used in the automated test and it looks not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added #163 which gives sync()
the ability to time warp the devnet.
Since all of these quasi-tests execute on bun run devnet
, could we add a flag (see: --procLog
), which either enables or disables them?
And I suggest moving all of the functions into a single function in testNames.ts
.
// runDevnet.ts
import { testNames } from "./testNames.js";
...
// add "--testNames" to parser
...
if (args.values.testNames) {
await testNames(env);
}
// testNames.ts
async function testNames(...) {
await registerTestNames(env, ...);
await transferName(env, ...);
await renewName(env, ...);
...
}
@adraffy PTAL |
Add test for the following scenarios so that external indexers have test transactions to index
wallet
)Still not done for
Out of scope