Fix bugs in feat/hono #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Claude settings configuration - Update example vars with localhost chain - Add localhost chain configuration in utils - Add error handling utilities - Update chains configuration with localhost support - Enhance owner resolution logic - Update worker configuration types - Update avatar route implementation 🤖 Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
- Remove debug console.log statements - Simplify HEAD request handling for unregistered headers - Maintain original functionality 🤖 Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
- Return null body for HEAD requests using c.body(null) - Maintain headers while returning no content for HEAD requests 🤖 Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
The test script was using 'vitest' which runs in watch mode and never exits. Changed to 'vitest run' to ensure tests complete and exit properly in CI. Added 'test:watch' script for local development with watch mode. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Created .test.vars with public RPC endpoints for tests - Updated vitest.config.ts to use .test.vars for environment variables - This ensures tests have required WEB3_ENDPOINT_MAP in CI environment 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This reverts commit 97ea1a1.
This reverts commit 2e7628a.
…on issue - Viem handles chainId differently for holesky during EIP-712 signature verification - While mainnet/goerli/sepolia don't add chainId when not explicitly provided, holesky does - This causes cross-chain signature verification to fail since test signatures use mainnet wallet - Added detailed comments explaining the exclusion 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Modified test workflow configuration - Updated avatar route integration tests 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Update avatar and header routes - Modify owner utility functions - Add new subname utility module 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Reorganize imports in avatar and header routes - Format subname utility code for consistency 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
svemat01
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.