Skip to content

Add search_fields attribute to SearchFilter #8834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add search_fields attribute to SearchFilter #8834

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5bdc44b
Add search_fields attribute to SearchFilter
ad-m-ss Jan 10, 2023
854e22b
Apply review commnents
ad-m-ss Feb 7, 2023
a0aefac
Fix lint
ad-m-ss Feb 11, 2023
c2921b1
Reduce diff
ad-m-ss Feb 23, 2023
a82e23c
apply review comments
ad-m-ss Feb 24, 2023
731c63f
Fix tests
ad-m-ss Mar 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion rest_framework/filters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,14 +48,15 @@ class SearchFilter(BaseFilterBackend):
}
search_title = _('Search')
search_description = _('A search term.')
search_fields = None

def get_search_fields(self, view, request):
"""
Search fields are obtained from the view, but the request is always
passed to this method. Sub-classes can override this method to
dynamically change the search fields based on request content.
"""
return getattr(view, 'search_fields', None)
return getattr(view, 'search_fields', getattr(self, 'search_fields'))

def get_search_terms(self, request):
"""
Expand Down