Allow pthread-based programs to be loaded cross-origin #25581
Conversation
sbc100
force-pushed
the
cross_origin_workers
branch
from
bbd5887 to
205fbb3
Compare
There was a problem hiding this comment.
I can't say I 100% understand the limitation here, but if the feedback from all the folks on the bug is that this workaround works and that the test represents their use case, then LGTM. I wonder if it's also worth running this change through the internal testing script before landing it.
|
Actually I guess the internal tester might not test serving in a prod environment, but maybe still worth doing. |
|
maybe also worth getting a review from one of our CDN-affiliated friends, such as @RReverser ? |
|
It's a known limitation & workaround, but I suspect we might want to put it behind a separate flag, at least behind Blob URLs can be prohibited by CSP policies, and in fixing the cross-origin usecase we can break the much more common same-origin one if the origin happens to use stricter security policy that prohibits dynamically created JS / resources in general. |
sbc100
force-pushed
the
cross_origin_workers
branch
2 times, most recently
from
d43946b to
dd3e9cc
Compare
I mean I was able to repro the exactly failure.. so this change does provably solve a version of this issue for sure. And the folks on the bug talk about this workaround working for them. So I'm pretty confident this is a working fix. |
sbc100
force-pushed
the
cross_origin_workers
branch
from
dd3e9cc to
e37940f
Compare
|
Added a new setting. |
sbc100
force-pushed
the
cross_origin_workers
branch
2 times, most recently
from
3616d98 to
6d39f04
Compare
sbc100
force-pushed
the
cross_origin_workers
branch
from
6d39f04 to
7bb2093
Compare
For some reason creating new workers across origins is not allowed, even when `importScripts` is. Added a test case which was confirmed to fail without this PR. Fixes: emscripten-core#21937
sbc100
force-pushed
the
cross_origin_workers
branch
from
7bb2093 to
0f5c761
Compare
This setting was recently added in emscripten-core#25581 and it only currently has en effect on pthread-based programs. It is also not compatible with `-sNO_DYNAMIC_EXECUTION` because it depends on starting worker based on JS string. These errors look like this: ``` $ emcc -sCROSS_ORIGIN -pthread -sDYNAMIC_EXECUTION=0 hello.c emcc: error: CROSS_ORIGIN is not compatible with DYNAMIC_EXECUTION=0 ```
This setting was recently added in #25581 and it only currently has en effect on pthread-based programs. It is also not compatible with `-sNO_DYNAMIC_EXECUTION` because it depends on starting worker based on JS string. These errors look like this: ``` $ emcc -sCROSS_ORIGIN -pthread -sDYNAMIC_EXECUTION=0 hello.c emcc: error: CROSS_ORIGIN is not compatible with DYNAMIC_EXECUTION=0 ```
3 participants
For some reason creating new workers across origins is not allowed,
even when
importScriptsis.Added a test case which was confirmed to fail without this PR.
Fixes: #21937