Fix MINIMAL_RUNTIME_STREAMING_WASM_INSTANTIATION under node. NFC #24782
+8
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We cannot actually use this API under node since the fetch API doesn't support local files. However, this failure was going undetected for two reason: 1. The test was only looking for the string 'hello' in the output which also appears in backtraces. 2. The instantiation error was being swallowed by a catch block that simply printed the error the console, so the node process was exiting with success.
kripken
approved these changes
Jul 24, 2025
Co-authored-by: Alon Zakai <alonzakai@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cannot actually use this API under node since the fetch API doesn't support local files.
However, this failure was going undetected for two reason: