[test] Simplify test_pthread_tls. NFC #24658
Merged
+19
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
test_pthread_tls
branch
2 times, most recently
from
f6fa5a3 to
d0ebd9f
Compare
kripken
reviewed
Jul 8, 2025
test/test_core.py
Outdated
| @@ -2714,6 +2707,14 @@ def test_pthread_tls_dylink(self): | |||
| self.cflags.append('-Wno-experimental') | |||
| self.do_run_in_out_file_test('pthread/test_pthread_tls_dylink.c') | |||
|
|
|||
| @node_pthreads | |||
| @needs_dylink | |||
There was a problem hiding this comment.
Ooops, copypasta. Removed.
- Convert to C - Run in core tests under node. - Remove redundant test added in emscripten-core#24646
kripken
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.