Change standalone wasm vm tests to emit a test skip when wasm engine is not present #24631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is not present, rather than print a warning and then possibly fail. Fixes `test/runner core2g.test_eval_ctors_standalone` without a Wasm engine present.
kripken
reviewed
Jun 30, 2025
| @@ -1983,7 +1983,7 @@ def _build_and_run(self, filename, expected_output, args=None, | |||
| # TODO once standalone wasm support is more stable, apply use_all_engines | |||
| # like with js engines, but for now as we bring it up, test in all of them | |||
| if not self.wasm_engines: | |||
| logger.warning('no wasm engine was found to run the standalone part of this test') | |||
| self.skipTest('no wasm engine was found to run the standalone part of this test') | |||
There was a problem hiding this comment.
It might be safer to do what we do for various features like this:
Lines 1053 to 1056 in ca3d456
We error by default, so we can't forget to set up all the test requirements, and we allow manual opt-out instead of opt-in.
There was a problem hiding this comment.
Yes, something like EMTEST_SKIP_WASM_ENGINE probably makes the most sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change standalone wasm vm tests to emit a test skip when wasm engine is not present, rather than print a warning and then possibly fail. Fixes
test/runner core2g.test_eval_ctors_standalonewithout a Wasm engine present.