-
Notifications
You must be signed in to change notification settings - Fork 47
Support vendor widevine library (reworked) #311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support vendor widevine library (reworked) #311
Conversation
d6054fc
to
f8b6d19
Compare
The information pane will look like this:
|
@samnazarko Is there any progress from your side on this? Have you tested this implementation? |
I’ll check this shortly
Sam
On 14 Apr 2020, at 17:24, Dag Wieers <notifications@github.com> wrote:
@samnazarko<https://github.com/samnazarko> Is there any progress from your side on this? Have you tested this implementation?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#311 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAHDWLCZSJ5UB5LF4GIFHIDRMSE2NANCNFSM4MH24THA>.
|
ca98006
to
75a8c84
Compare
It's not clear to me where my libwidevinecdm_vendor.so should go. I can only see references to it in the unit tests and couldn't see any other code that references it elsewhere. I overwrote libwidevinecdm.so instead -- version info looked sane, but haven't been able to test other functionality yet. Cheers, Sam |
@samnazarko AFAIK It is in the same location as where it currently lives, but with a vendor-label added. On a Linux system it would be in ~/.kodi/cdm/ Also see: #229 (comment) |
This adds support for a vendor-supported Widevine library.
75a8c84
to
31fd823
Compare
OK, I'll give this a test tomorrow. Thanks Dag Sam |
Hi Dag - just to let you know, this isn't forgotten. I'm currently having to port over Widevine15 changes which is proving tricky. |
@samnazarko We have started working on the upcoming v0.5.0 release which greatly improves extracting the Widevine CDM for ARM devices. It would be nice if this could ship with v0.5.0. |
We have made some progress on porting Widevine 15 and passing user acceptance testing.
I should be able to check this again next week.
On 5 May 2020, at 17:06, Dag Wieers <notifications@github.com> wrote:
@samnazarko<https://github.com/samnazarko> We have started working on the upcoming v0.5.0 release which greatly improves extracting the Widevine CDM for ARM devices. It would be nice if this could ship with v0.5.0.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#311 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAHDWLACN647IWHXIRGASLTRQA2QTANCNFSM4MH24THA>.
|
Hi @dagwieers -- sorry for the late reply and to keep you waiting. I think you can get this merged. The new Widevine changes mean that we may not be able to use InputStream directly, but it can at least display the correct information about the present Widevine library. |
@samnazarko Thanks for the feedback. @mediaminister @horstle Is there something we want to add to this? |
No, I would like to know how this can be tested. |
The install/remove options from the settings page might create issues? |
All good points. Since this PR is again obsoleted by recent changes I am going to close it. |
I'll have a look at it in the next few days, but it almost certainly won't be ready for v0.5.0, which imo should be released this weekend, even if some translations might still be missing. |
This adds support for a vendor-supported Widevine library.
TODO:
Get timestamp from library to show in info paneThis is PR #240 reworked and fixes #229