Skip to content

Support vendor widevine library (reworked) #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

dagwieers
Copy link
Collaborator

@dagwieers dagwieers commented Apr 14, 2020

This adds support for a vendor-supported Widevine library.

TODO:

  • Get timestamp from library to show in info pane
  • Disable settings/operations

This is PR #240 reworked and fixes #229

@dagwieers dagwieers added this to the v0.5.0 milestone Apr 14, 2020
@dagwieers dagwieers force-pushed the vendor-widevine-reworked branch 2 times, most recently from d6054fc to f8b6d19 Compare April 14, 2020 16:12
@dagwieers
Copy link
Collaborator Author

The information pane will look like this:

Kodi information

  • Kodi version: 18.6
  • Kodi platform/architecture: Linux/arm

InputStream information

  • InputStream Helper version: 0.4.5
  • InputStream Adaptive version: 2.4.4

Widevine information

  • Widevine version: 4.10.1440.18 (supplied by vendor)

Please report issues to:

@dagwieers
Copy link
Collaborator Author

@samnazarko Is there any progress from your side on this? Have you tested this implementation?

@samnazarko
Copy link

samnazarko commented Apr 14, 2020 via email

@dagwieers dagwieers force-pushed the vendor-widevine-reworked branch 6 times, most recently from ca98006 to 75a8c84 Compare April 14, 2020 20:41
@samnazarko
Copy link

samnazarko commented Apr 16, 2020

It's not clear to me where my libwidevinecdm_vendor.so should go. I can only see references to it in the unit tests and couldn't see any other code that references it elsewhere.

I overwrote libwidevinecdm.so instead -- version info looked sane, but haven't been able to test other functionality yet.

Cheers,

Sam

@dagwieers
Copy link
Collaborator Author

dagwieers commented Apr 16, 2020

@samnazarko AFAIK It is in the same location as where it currently lives, but with a vendor-label added. On a Linux system it would be in ~/.kodi/cdm/

Also see: #229 (comment)

This adds support for a vendor-supported Widevine library.
@dagwieers dagwieers force-pushed the vendor-widevine-reworked branch from 75a8c84 to 31fd823 Compare April 16, 2020 00:37
@dagwieers dagwieers marked this pull request as draft April 16, 2020 00:44
@samnazarko
Copy link

OK, I'll give this a test tomorrow.

Thanks Dag

Sam

@samnazarko
Copy link

Hi Dag - just to let you know, this isn't forgotten. I'm currently having to port over Widevine15 changes which is proving tricky.

@dagwieers
Copy link
Collaborator Author

@samnazarko We have started working on the upcoming v0.5.0 release which greatly improves extracting the Widevine CDM for ARM devices. It would be nice if this could ship with v0.5.0.

@samnazarko
Copy link

samnazarko commented May 5, 2020 via email

@mediaminister mediaminister modified the milestones: v0.5.0, Future Jun 13, 2020
@samnazarko
Copy link

Hi @dagwieers -- sorry for the late reply and to keep you waiting.

I think you can get this merged. The new Widevine changes mean that we may not be able to use InputStream directly, but it can at least display the correct information about the present Widevine library.

@dagwieers
Copy link
Collaborator Author

@samnazarko Thanks for the feedback.

@mediaminister @horstle Is there something we want to add to this?

@dagwieers dagwieers marked this pull request as ready for review June 22, 2020 15:33
@mediaminister
Copy link
Collaborator

No, I would like to know how this can be tested.

@horstle
Copy link
Collaborator

horstle commented Jun 22, 2020

The install/remove options from the settings page might create issues?

@dagwieers
Copy link
Collaborator Author

All good points. Since this PR is again obsoleted by recent changes I am going to close it.
Feel free to pursue this if you have a need for this.

@horstle
Copy link
Collaborator

horstle commented Jun 23, 2020

I'll have a look at it in the next few days, but it almost certainly won't be ready for v0.5.0, which imo should be released this weekend, even if some translations might still be missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support vendor distributed Widevine
4 participants