-
Couldn't load subscription status.
- Fork 157
Add enableInternalCssProcessing option for webpack
#2253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: stable
Are you sure you want to change the base?
Add enableInternalCssProcessing option for webpack
#2253
Conversation
|
I just noticed that you're targeting main here 🙈 main Webpack support doesn't work yet and it won't work this way any more, it will have its own webpack config when we eventually release it |
|
Yeah, I switched to stable and there were 388 files in this PR 🙈. So I changed back until I had time to merge stable back in locally and push up a correct PR. |
9249bff to
9cc4451
Compare
disableCssProcessing option for webpackenableInternalCssProcessing option for webpack
|
@mansona I've got this targeting the stable branch now. |
|
Is this still needed, given we have #2299 now? |
|
I think so, you still end up with two rules processing css files when you use a custom pipeline, doubling the workload. |
|
I was going to suggest that we try to test this but tbh I don't think it's worth putting the effort in for something like this. If you just add some sort of documentation for this somewhere (maybe the readme?) then we should be able to merge this 👍 |
061c470 to
32d8f41
Compare
|
I've added documentation to the readme, the failing tests I'm pretty sure are just flaky windows issues. |
|
@mansona Anything else for me to do on this? |
When an app provides it's own webpack css pipeline there is no reason for the default webpack config to also process css files, you can end up with multiple versions of the same file output into the build and loaded by the JS chunks (eg. renaming the css files by configuring MiniCssExtractPlugin yourself).
I'm not sure how to add a test for this, some guidance here would be helpful. Do I add a new scenario? Do I just add a test to an existing scenario?
Some documentation should be added to explain this option.