Skip to content

Commit 21d5a7a

Browse files
Use relative path for references instead of versioned url paths
1 parent 9921fb7 commit 21d5a7a

File tree

3 files changed

+3
-4
lines changed

3 files changed

+3
-4
lines changed

guides/v3.1.0/components/the-component-lifecycle.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ export default Component.extend({
172172
[`didInsertElement()`][did-insert-element] is also a good place to
173173
attach event listeners. This is particularly useful for custom events or
174174
other browser events which do not have a [built-in event
175-
handler][event-names].
175+
handler](../components/handling-events/#toc_event-names).
176176

177177
For example, perhaps you have some custom CSS animations trigger when the component
178178
is rendered and you want to handle some cleanup when it ends:
@@ -201,7 +201,6 @@ There are a few things to note about the `didInsertElement()` hook:
201201

202202
[did-insert-element]: https://www.emberjs.com/api/ember/release/classes/Component/events/didInsertElement?anchor=didInsertElement
203203
[dollar]: https://www.emberjs.com/api/ember/release/classes/Component/methods/$?anchor=%24
204-
[event-names]: http://guides.emberjs.com/v2.1.0/components/handling-events/#toc_event-names
205204

206205
### Making Updates to the Rendered DOM with `didRender`
207206

guides/v3.1.0/testing/index.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ If we need to test the functionality around an Ember class instance, such as a C
3838

3939
To setup the application’s container, we import the [ember-qunit](https://github.com/emberjs/ember-qunit) addon which provides us with QUnit-specific wrappers around the helpers contained in [ember-test-helpers](https://github.com/emberjs/ember-test-helpers).
4040

41-
In the example below, we import the `setupTest` function from `ember-qunit` and call it with the `hooks` object to setup the test context with access to the `this.owner` property. This provides us direct container access to interact with Ember's [Dependency Injection](https://guides.emberjs.com/v3.0.0/applications/dependency-injection/) system. Direct container access allows us to [lookup](https://emberjs.com/api/ember/release/classes/ApplicationInstance/methods/lookup?anchor=lookup) everything in the application container, like Controllers, Routes, or Services in order to have an instance of it to test in our QUnit test module.
41+
In the example below, we import the `setupTest` function from `ember-qunit` and call it with the `hooks` object to setup the test context with access to the `this.owner` property. This provides us direct container access to interact with Ember's [Dependency Injection](../applications/dependency-injection/) system. Direct container access allows us to [lookup](https://emberjs.com/api/ember/release/classes/ApplicationInstance/methods/lookup?anchor=lookup) everything in the application container, like Controllers, Routes, or Services in order to have an instance of it to test in our QUnit test module.
4242

4343
For example, the following is a Container Test for the `flash-messages` service:
4444

guides/v3.1.0/tutorial/hbs-helper.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ export function rentalPropertyType([propertyType]) {
8585
export default helper(rentalPropertyType);
8686
```
8787

88-
Each [argument](https://guides.emberjs.com/v2.12.0/templates/writing-helpers/#toc_helper-arguments) in the helper will be added to an array and passed to our helper. For example, `{{my-helper "foo" "bar"}}` would result in `myHelper(["foo", "bar"])`. Using array [ES2015 destructuring](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Destructuring_assignment) assignment, we can name expected parameters within the array. In the example above, the first argument in the template will be assigned to `propertyType`. This provides a flexible, expressive interface for your helpers, including optional arguments and default values.
88+
Each [argument](../templates/writing-helpers/#toc_helper-arguments) in the helper will be added to an array and passed to our helper. For example, `{{my-helper "foo" "bar"}}` would result in `myHelper(["foo", "bar"])`. Using array [ES2015 destructuring](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Destructuring_assignment) assignment, we can name expected parameters within the array. In the example above, the first argument in the template will be assigned to `propertyType`. This provides a flexible, expressive interface for your helpers, including optional arguments and default values.
8989

9090
Now in our browser we should see that the first rental property is listed as "Standalone",
9191
while the other two are listed as "Community".

0 commit comments

Comments
 (0)