Skip to content

Commit 9921fb7

Browse files
robbiewainsivakumar-kailasam
authored andcommitted
Fix code example: jQuery position is a function
1 parent 727d042 commit 9921fb7

File tree

18 files changed

+19
-18
lines changed

18 files changed

+19
-18
lines changed

guides/v2.10.0/components/the-component-lifecycle.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,7 @@ export default Ember.Component.extend({
239239

240240
didRender() {
241241
this._super(...arguments);
242-
this.$('.item-list').scrollTop(this.$('.selected-item').position.top);
242+
this.$('.item-list').scrollTop(this.$('.selected-item').position().top);
243243
}
244244
});
245245
```

guides/v2.11.0/components/the-component-lifecycle.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,7 @@ export default Ember.Component.extend({
239239

240240
didRender() {
241241
this._super(...arguments);
242-
this.$('.item-list').scrollTop(this.$('.selected-item').position.top);
242+
this.$('.item-list').scrollTop(this.$('.selected-item').position().top);
243243
}
244244
});
245245
```

guides/v2.12.0/components/the-component-lifecycle.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,7 @@ export default Ember.Component.extend({
239239

240240
didRender() {
241241
this._super(...arguments);
242-
this.$('.item-list').scrollTop(this.$('.selected-item').position.top);
242+
this.$('.item-list').scrollTop(this.$('.selected-item').position().top);
243243
}
244244
});
245245
```

guides/v2.13.0/components/the-component-lifecycle.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,7 @@ export default Ember.Component.extend({
239239

240240
didRender() {
241241
this._super(...arguments);
242-
this.$('.item-list').scrollTop(this.$('.selected-item').position.top);
242+
this.$('.item-list').scrollTop(this.$('.selected-item').position().top);
243243
}
244244
});
245245
```

guides/v2.14.0/components/the-component-lifecycle.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,7 @@ export default Ember.Component.extend({
239239

240240
didRender() {
241241
this._super(...arguments);
242-
this.$('.item-list').scrollTop(this.$('.selected-item').position.top);
242+
this.$('.item-list').scrollTop(this.$('.selected-item').position().top);
243243
}
244244
});
245245
```

guides/v2.15.0/components/the-component-lifecycle.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,7 @@ export default Ember.Component.extend({
248248

249249
didRender() {
250250
this._super(...arguments);
251-
this.$('.item-list').scrollTop(this.$('.selected-item').position.top);
251+
this.$('.item-list').scrollTop(this.$('.selected-item').position().top);
252252
}
253253
});
254254
```

guides/v2.16.0/components/the-component-lifecycle.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ export default Component.extend({
247247

248248
didRender() {
249249
this._super(...arguments);
250-
this.$('.item-list').scrollTop(this.$('.selected-item').position.top);
250+
this.$('.item-list').scrollTop(this.$('.selected-item').position().top);
251251
}
252252
});
253253
```

guides/v2.17.0/components/the-component-lifecycle.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ export default Component.extend({
247247

248248
didRender() {
249249
this._super(...arguments);
250-
this.$('.item-list').scrollTop(this.$('.selected-item').position.top);
250+
this.$('.item-list').scrollTop(this.$('.selected-item').position().top);
251251
}
252252
});
253253
```

guides/v2.18.0/components/the-component-lifecycle.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ export default Component.extend({
247247

248248
didRender() {
249249
this._super(...arguments);
250-
this.$('.item-list').scrollTop(this.$('.selected-item').position.top);
250+
this.$('.item-list').scrollTop(this.$('.selected-item').position().top);
251251
}
252252
});
253253
```

guides/v2.3.0/components/the-component-lifecycle.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,7 @@ export default Ember.Component.extend({
239239

240240
didRender() {
241241
this._super(...arguments);
242-
this.$('.item-list').scrollTop(this.$('.selected-item').position.top);
242+
this.$('.item-list').scrollTop(this.$('.selected-item').position().top);
243243
}
244244
});
245245
```

guides/v2.4.0/components/the-component-lifecycle.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,7 @@ export default Ember.Component.extend({
239239

240240
didRender() {
241241
this._super(...arguments);
242-
this.$('.item-list').scrollTop(this.$('.selected-item').position.top);
242+
this.$('.item-list').scrollTop(this.$('.selected-item').position().top);
243243
}
244244
});
245245
```

guides/v2.5.0/components/the-component-lifecycle.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,7 @@ export default Ember.Component.extend({
239239

240240
didRender() {
241241
this._super(...arguments);
242-
this.$('.item-list').scrollTop(this.$('.selected-item').position.top);
242+
this.$('.item-list').scrollTop(this.$('.selected-item').position().top);
243243
}
244244
});
245245
```

guides/v2.6.0/components/the-component-lifecycle.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,7 @@ export default Ember.Component.extend({
239239

240240
didRender() {
241241
this._super(...arguments);
242-
this.$('.item-list').scrollTop(this.$('.selected-item').position.top);
242+
this.$('.item-list').scrollTop(this.$('.selected-item').position().top);
243243
}
244244
});
245245
```

guides/v2.7.0/components/the-component-lifecycle.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,7 @@ export default Ember.Component.extend({
239239

240240
didRender() {
241241
this._super(...arguments);
242-
this.$('.item-list').scrollTop(this.$('.selected-item').position.top);
242+
this.$('.item-list').scrollTop(this.$('.selected-item').position().top);
243243
}
244244
});
245245
```

guides/v2.8.0/components/the-component-lifecycle.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,7 @@ export default Ember.Component.extend({
239239

240240
didRender() {
241241
this._super(...arguments);
242-
this.$('.item-list').scrollTop(this.$('.selected-item').position.top);
242+
this.$('.item-list').scrollTop(this.$('.selected-item').position().top);
243243
}
244244
});
245245
```

guides/v2.9.0/components/the-component-lifecycle.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,7 @@ export default Ember.Component.extend({
239239

240240
didRender() {
241241
this._super(...arguments);
242-
this.$('.item-list').scrollTop(this.$('.selected-item').position.top);
242+
this.$('.item-list').scrollTop(this.$('.selected-item').position().top);
243243
}
244244
});
245245
```

guides/v3.0.0/components/the-component-lifecycle.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ export default Component.extend({
247247

248248
didRender() {
249249
this._super(...arguments);
250-
this.$('.item-list').scrollTop(this.$('.selected-item').position.top);
250+
this.$('.item-list').scrollTop(this.$('.selected-item').position().top);
251251
}
252252
});
253253
```

guides/v3.1.0/components/the-component-lifecycle.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ Listed below are the component lifecycle [hooks](../../getting-started/core-conc
3333

3434
## Lifecycle Hook Examples
3535

36+
3637
Below are some samples of ways to use lifecycle hooks within your components.
3738

3839
### Resetting Presentation State on Attribute Change with `didUpdateAttrs`
@@ -247,7 +248,7 @@ export default Component.extend({
247248

248249
didRender() {
249250
this._super(...arguments);
250-
this.$('.item-list').scrollTop(this.$('.selected-item').position.top);
251+
this.$('.item-list').scrollTop(this.$('.selected-item').position().top);
251252
}
252253
});
253254
```

0 commit comments

Comments
 (0)