Skip to content

Commit a2c52d4

Browse files
authored
Merge pull request #550 from ember-codemods/no-telemetry
2 parents e689b90 + 3a00e78 commit a2c52d4

40 files changed

+368
-195
lines changed

.gitignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
11
node_modules
22
*.log
33
.eslintcache
4+
transforms/**/*.js
5+
!transforms/ember-object/__testfixtures__/**/*.js

README.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,14 @@ If you have any _lazily loaded_ modules, such as modules from Ember Engines,
5050
you'll need to make sure that the URL you provide loads these modules as well.
5151
Otherwise, the codemod will not be able to detect them or analyze them.
5252

53+
To disable this feature, run with `NO_TELEMETRY=true` and omit the path to your local server:
54+
55+
```shell
56+
NO_TELEMETRY=true npx ember-native-class-codemod [OPTIONS] path/of/files/ or/some**/*glob.js
57+
```
58+
59+
DANGER: Disabling the telemetry may result in incorrect behavior. Carefully vet the results.
60+
5361
### Types
5462

5563
The `type` option can be used to further narrow down transforms to a particular type of

bin/cli.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,11 @@
44
const { gatherTelemetryForUrl, analyzeEmberObject } = require('ember-codemods-telemetry-helpers');
55

66
(async () => {
7-
await gatherTelemetryForUrl(process.argv[2], analyzeEmberObject);
7+
let args = process.argv.slice(1);
8+
if (process.env['NO_TELEMETRY'] !== 'true') {
9+
await gatherTelemetryForUrl(process.argv[2], analyzeEmberObject);
10+
args = process.argv.slice(2);
11+
}
812

9-
require('codemod-cli').runTransform(
10-
__dirname,
11-
'ember-object',
12-
process.argv.slice(2) /* paths or globs */
13-
);
13+
require('codemod-cli').runTransform(__dirname, 'ember-object', args);
1414
})();

transforms/ember-object/__testfixtures__/-mock-telemetry.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
{
22
"runtime": {
33
"computedProperties": ["computedMacro", "anotherMacro", "numPlusOne", "numPlusPlus", "error", "errorService"],
4-
"observedProperties": [],
5-
"observerProperties": {},
4+
"observedProperties": ["prop"],
5+
"observerProperties": { "observerProp": ["prop"] },
66
"offProperties": { "offProp": ["prop1", "prop2"] },
77
"overriddenActions": ["overriddenActionMethod"],
88
"overriddenProperties": ["overriddenMethod"],
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
{
2+
"noTelemetry": "false"
3+
}
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
{
2+
"noTelemetry": "false"
3+
}
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
{
2+
"noTelemetry": false
3+
}
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
{
2+
"noTelemetry": false
3+
}
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
{
2+
"noTelemetry": false
3+
}
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
{
2+
"noTelemetry": false
3+
}

0 commit comments

Comments
 (0)