Skip to content

Commit e689b90

Browse files
authored
Merge pull request #548 from ember-codemods/fix-service-call
2 parents 951005f + 618bdc6 commit e689b90

File tree

9 files changed

+40
-4
lines changed

9 files changed

+40
-4
lines changed

.gitignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
11
node_modules
22
*.log
33
.eslintcache
4-
transforms/**/*.js

.vscode/settings.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
"editor.formatOnSave": true,
33
"editor.defaultFormatter": "esbenp.prettier-vscode",
44
"editor.codeActionsOnSave": {
5-
"source.fixAll": true,
6-
"source.organizeImports": true
5+
"source.fixAll": "explicit",
6+
"source.organizeImports": "explicit"
77
},
88
"typescript.preferences.importModuleSpecifierEnding": "index",
99
"typescript.suggest.autoImports": true

package.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,5 +88,9 @@
8888
},
8989
"publishConfig": {
9090
"registry": "https://registry.npmjs.org"
91+
},
92+
"volta": {
93+
"node": "16.20.2",
94+
"yarn": "1.22.21"
9195
}
9296
}
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
import { inject as controller } from '@ember/controller';
2+
import { inject as service } from '@ember/service';
3+
4+
const Foo1 = EmberObject.extend({
5+
b: service('store'),
6+
myController: controller('abc'),
7+
});
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
import classic from 'ember-classic-decorator';
2+
import { inject as controller } from '@ember/controller';
3+
import { inject as service } from '@ember/service';
4+
5+
@classic
6+
class Foo1 extends EmberObject {
7+
@service('store')
8+
b;
9+
10+
@controller('abc')
11+
myController;
12+
}

transforms/ember-object/__testfixtures__/runtime.output.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
import classic from 'ember-classic-decorator';
22
import { off, unobserves } from '@ember-decorators/object';
33
import { action, computed } from '@ember/object';
4+
import { service } from '@ember/service';
45
import { alias } from '@ember/object/computed';
56
import Runtime from 'common/runtime';
6-
import { service } from '@ember/service';
77

88
/**
99
* Program comments
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
import { service } from '@ember/service';
2+
3+
const Foo1 = EmberObject.extend({
4+
b: service('store'),
5+
});
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
import classic from 'ember-classic-decorator';
2+
import { service } from '@ember/service';
3+
4+
@classic
5+
class Foo1 extends EmberObject {
6+
@service('store')
7+
b;
8+
}

transforms/helpers/util/index.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ export const DECORATOR_PATHS: ReadonlyMap<string, DecoratorPathInfo> = new Map([
7373
{
7474
importPropDecoratorMap: {
7575
inject: 'inject',
76+
service: 'service',
7677
},
7778
decoratorPath: '@ember/service',
7879
},

0 commit comments

Comments
 (0)