Skip to content

Commit ece6c22

Browse files
committed
Update ember-cli and friends
- Use yarn - Remove bower - Remove files unnecessary for a node addon - Switch from jshint to eslint - Clean up tests
1 parent a8e4bf2 commit ece6c22

39 files changed

+5449
-376
lines changed

.bowerrc

Lines changed: 0 additions & 4 deletions
This file was deleted.

.eslintrc.js

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
module.exports = {
2+
root: true,
3+
parserOptions: {
4+
ecmaVersion: 6,
5+
sourceType: 'module'
6+
},
7+
extends: 'eslint:recommended',
8+
env: {
9+
browser: true
10+
},
11+
rules: {
12+
}
13+
};

.jshintrc

Lines changed: 0 additions & 32 deletions
This file was deleted.

.travis.yml

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,19 @@
11
---
22
language: node_js
33
node_js:
4-
- "0.12"
4+
- "6"
55

66
sudo: false
77

88
cache:
9-
directories:
10-
- node_modules
11-
12-
matrix:
13-
fast_finish: true
9+
yarn: true
1410

1511
before_install:
16-
- "npm config set spin false"
17-
- "npm install -g npm@^2"
12+
- curl -o- -L https://yarnpkg.com/install.sh | bash
13+
- export PATH=$HOME/.yarn/bin:$PATH
1814

1915
install:
20-
- npm install
16+
- yarn install --no-lockfile
2117

2218
script:
23-
- npm test
19+
- yarn test

Brocfile.js

Lines changed: 0 additions & 16 deletions
This file was deleted.

README.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,10 @@ to see how you can customize your messages.
138138

139139
## Running Tests
140140

141-
- `npm test`
141+
* `yarn test`
142+
143+
## Why `ember build` and `ember test` don't work
144+
145+
Since this is a node-only ember-cli addon, this package does not include many files and dependencies which are part of ember-cli's typical `ember build` and `ember test` processes.
142146

143147
[2]: http://ember-cli-deploy.com/docs/v0.6.x/plugins-overview/ "Plugin Documentation"

addon/.gitkeep

Whitespace-only changes.

app/.gitkeep

Whitespace-only changes.

bower.json

Lines changed: 0 additions & 16 deletions
This file was deleted.

index.js

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
1-
/* jshint node: true */
1+
/*eslint-env node*/
22
'use strict';
33

4-
var SilentError = require('silent-error');
54
var SlackNotifier = require('./lib/slack-notifier');
65
var DeployPluginBase = require('ember-cli-deploy-plugin');
76

@@ -16,15 +15,15 @@ module.exports = {
1615
defaultConfig: {
1716
enabled: true,
1817

19-
willDeploy: function(context) {
20-
return function(slack){
18+
willDeploy: function(/* context */) {
19+
return function(/* slack */){
2120
return {
2221
slackStartDeployDate: new Date()
2322
};
2423
}
2524
},
2625

27-
didDeploy: function(context) {
26+
didDeploy: function(/* context */) {
2827
return function(slack){
2928
var startDeployDate = this.context.slackStartDeployDate;
3029
var endDeployDate = new Date();
@@ -48,7 +47,7 @@ module.exports = {
4847
};
4948
},
5049

51-
didFail: function(context) {
50+
didFail: function(/* context */) {
5251
return function(slack) {
5352
var message = "Ember-cli-deploy tried to deploy a revision but failed.";
5453

0 commit comments

Comments
 (0)