Skip to content

Commit a8e4bf2

Browse files
Merge pull request #17 from leizhao4/master
Replace deprecated `ember-cli/ext/promise` with `rsvp`
2 parents 7196f00 + 80dedf9 commit a8e4bf2

File tree

6 files changed

+8
-9
lines changed

6 files changed

+8
-9
lines changed

bin/changelog

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,11 @@
1313

1414
var EOL = require('os').EOL;
1515
var multiline = require('multiline');
16-
var Promise = require('ember-cli/lib/ext/promise');
16+
var RSVP = require('rsvp');
1717
var GitHubApi = require('github');
1818

1919
var github = new GitHubApi({version: '3.0.0'});
20-
var compareCommits = Promise.denodeify(github.repos.compareCommits);
20+
var compareCommits = RSVP.denodeify(github.repos.compareCommits);
2121
var currentVersion = 'v' + require('../package').version;
2222

2323
var user = 'ember-cli-deploy';

index.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
/* jshint node: true */
22
'use strict';
33

4-
var Promise = require('ember-cli/lib/ext/promise');
54
var SilentError = require('silent-error');
65
var SlackNotifier = require('./lib/slack-notifier');
76
var DeployPluginBase = require('ember-cli-deploy-plugin');

lib/slack-notifier.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
var Promise = require('ember-cli/lib/ext/promise');
1+
var RSVP = require('rsvp');
22
var CoreObject = require('core-object');
33
var Slack = require ('node-slackr');
44

@@ -9,7 +9,7 @@ module.exports = CoreObject.extend({
99
this.slack = new Slack(this.webhookURL, this._getSlackOptions());
1010

1111
this.notify = function(message) {
12-
return new Promise(function(resolve, reject) {
12+
return new RSVP.Promise(function(resolve, reject) {
1313
if (this.enabled) {
1414
this.slack.notify(message, function(error, result) {
1515
if (error) { return reject(error); }

node-tests/unit/index-test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
'use strict';
2-
var Promise = require('ember-cli/lib/ext/promise');
2+
var RSVP = require('rsvp');
33
var assert = require('ember-cli/tests/helpers/assert');
44

55
var WEBHOOK_URL = 'https://hooks.slack.com/services/123123';
@@ -156,7 +156,7 @@ describe('the index', function() {
156156
slackNotifier: {
157157
notify: function(message){
158158
slackMessages.push(message);
159-
return Promise.resolve();
159+
return RSVP.resolve();
160160
}
161161
}
162162
}

node-tests/unit/slack-test.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
var expect = require('chai').expect;
22
var sinon = require('sinon');
3-
var Slack = require('node-slackr');
3+
var Slack = require('node-slackr');
44
var SlackNotifier = require('../../lib/slack-notifier.js');
5-
var Promise = require('ember-cli/lib/ext/promise');
65

76
var WEBHOOK_URL = 'https://hooks.slack.com/services/123123';
87
var CHANNEL = '#testing';

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@
5353
"ember-cli-deploy-plugin": "^0.2.1",
5454
"moment": "^2.17.1",
5555
"node-slackr": "^0.1.0",
56+
"rsvp": "^3.4.0",
5657
"silent-error": "^1.0.0"
5758
},
5859
"ember-addon": {

0 commit comments

Comments
 (0)