Add a customise option to not grab the keyboard in full screen mode. #137
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Especially when using multiple monitors, I am not a fan of EXWM automatically switching X windows to
char mode
upon entering full screen. I understand the reasoning and think it should remain the default, since the unprepared user might otherwise accidentally open an invisibleM-x
menu behind their video player and become very sad.However, I would argue that users who know what they are doing should have the option of staying in
line mode
. Personally, I often have a full screen video player or game running on one monitor while also using a chat client on another monitor, and if the game is in char mode, I cannot use my regular keybinds to quickly reply to chat messages. I do not want to add those keybinds toexwm-input-global-keys
since that would mess up my workflow in windows where I enterchar mode
on purpose.I think adding a customise option for this is a small change that has a benefit for at least some users at essentially no performance impact.
PS: Please let me know if in the future I should open an issue first rather than creating a pull request immediately.