Skip to content

fix: 🐛 prevent failed to fetch spec from URL error #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jimmy-guzman
Copy link
Contributor

@jimmy-guzman jimmy-guzman commented Oct 13, 2024

There was a regression introduced with Fix nested path issue in Swagger and Scalar config #146 which was meant to fix #135, when path is either "/" or "" it leads to Failed to fetch spec from URL or ERR_NAME_NOT_RESOLVED because the url becomes "http://json/".

I can create a new issue but it might address #151

I also noticed that excludePaths might not be working as intended for when path is either "/" or "" but that's always been the behavior so I didn't address that.

@ClayenKitten
Copy link

Hey, @SaltyAom, can we get that merged please?

@SaltyAom SaltyAom merged commit f2b62fa into elysiajs:main Jan 20, 2025
@bhaleraosaurabh
Copy link
Contributor

image

The path issue still persists.

Its fixed in #185. Could we please have it merged? @SaltyAom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested paths as path config doesn't work
4 participants