[chore] Removed umbrella application #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our application is now a set of normal, independent mix applications residing under the app directory.
|
Note, this isn't ready for review, i still need to update the build steps. |
mhanberg
approved these changes
Feb 20, 2025
Read this after I clicked approve 🤣 |
scohen
changed the title
Sometimes, the target of a `{:for, _}` tuple is not an atom. Treating
it like a module is incorrect
Removed elixir file caches and projects directory (which doesn't exist any more). We do update this cache on every run. The thinking here is to minimize the changes in the PLT by keeping more of our updated code in the plts.
|
@lukaszsamson @mhanberg The PR is ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our application is now a set of normal, independent mix applications residing under the app directory.