Remove projects directories from expert #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did each move in a separate commit to aid reviews. |
scohen
force-pushed
the
remove-projects
branch
from
a9bc409 to
d21da44
Compare
|
@mhanberg @lukaszsamson PTAL. I could only add a single reviewer fro some reason. |
scohen
force-pushed
the
remove-projects
branch
from
d21da44 to
7bfa09c
Compare
scohen
force-pushed
the
remove-projects
branch
from
7bfa09c to
3beae56
Compare
scohen
changed the title
lukaszsamson
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're moving expert from the current setup of an umbrella + projects hybrid to a poncho project with clearer dependencies. This is the first step where we push a bunch of the projects into the current umbrella.
The next stage will remove the projects from the umbrella and make this project into a poncho.