Skip to content

fix: support Fish shell's space-separated PATH format #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+10 −1
Open

fix: support Fish shell's space-separated PATH format #172

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97e6961
fix: support Fish shell's space-separated PATH format
nickgnd Oct 18, 2025
bce3abb
chore: improve comments
nickgnd Oct 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion apps/expert/lib/expert/port.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,16 @@ defmodule Expert.Port do
# managed programs.
shell = System.get_env("SHELL")

{path, 0} = System.cmd(shell, ["-i", "-l", "-c", "cd #{root_path} && echo $PATH"])
# Ideally, it should contain the path to shell (e.g. `/usr/bin/fish`),
# but it might contain only the name of the shell (e.g. `fish`).
is_fish? = String.contains?(shell, "fish")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can use Path.basename/1 here instead


# Fish uses space-separated PATH, so we use the built-in `string join` command
# to join the entries with colons and have a standard colon-separated PATH output
# as in bash, which is expected by `:os.find_executable/2`.
path_command = if is_fish?, do: "string join ':' $PATH", else: "echo $PATH"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: we prefer something like fish_shell?, is_x? mixes both naming conventions for guards and booleans


{path, 0} = System.cmd(shell, ["-i", "-l", "-c", "cd #{root_path} && #{path_command}"])

case :os.find_executable(~c"elixir", to_charlist(path)) do
false ->
Expand Down
Loading