[fix] Fix prefix_stream crashing on interpolations with newlines
#12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interpolations with newlines contain an `:eol` token in the shape of
`{:eol, positions}`, which `get_start_pos` wasn't considering, causing a
crash.
The solution I went for here is to just consider that token shape when
dealing with interpolation tokens. As far as I can see the tokens inside
the interpolation aren't being normalized, so I kept that behavior.
The test I added uses the `~S` sigil instead of the helper `~q` sigil. This
is due to the `~q` sigil escaping the interpolation in a way that didn't
reproduce the issue I saw in an Expert release.
The code in the new test is the snippet that caused the crashes while editing
Sourceror, so to reproduce this locally it's enough to paste that into a
project and try to trigger a completion like `Enum|`.
scohen
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11
Interpolations with newlines contain an
:eoltoken in the shape of{:eol, positions}, whichget_start_poswasn't considering, causing acrash.
The solution I went for here is to just consider that token shape when
dealing with interpolation tokens. As far as I can see the tokens inside
the interpolation aren't being normalized, so I kept that behavior.
The test I added uses the
~Ssigil instead of the helper~qsigil. Thisis due to the
~qsigil escaping the interpolation in a way that didn'treproduce the issue I saw in an Expert release.
The code in the new test is the snippet that caused the crashes while editing
Sourceror, so to reproduce this locally it's enough to paste that into a
project and try to trigger a completion like
Enum|.