Feature: allow to pass the app key through an environment variable #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the possibility to supply the GitHub application's private key through a new environment variable: `APP_KEY`. This is useful in CI/CDs where secrets may not be stored in files, and users may not wish to store them into an intermediary file. Note: there is no validation whether or not a private key was supplied as there wasn't any check in the original code either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the possibility to supply the GitHub application's private key through a new environment variable:
APP_KEY. This is useful in CI/CDs where secrets may not be stored in files, and users may not wish to store them into an intermediary file.Note: there is no validation whether or not a private key was supplied as there wasn't any check in the original code either. Let me know if you would like me to add a check.