Skip to content

Proxy Emulation class in RegenerateProductUrl #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

hostep
Copy link
Contributor

@hostep hostep commented Dec 28, 2023

Introduced another proxy in a constructor to avoid database access through bin/magento

This class isn't directly used in the Command classes, but the waterfall of constructors that get called eventually end up with this class.

Together with #78, this should fully fix #76

Tested on Magento 2.4.6-p3 (with magento/magento2#37424 as patch applied) and on the 2.4-develop branch of magento/magento2 github repo.

Copy link

what-the-diff bot commented Dec 28, 2023

PR Summary

  • Dependency Update in RegenerateProductUrl.php
    The update in this file modifies the original dependency ProductUrlRewriteGenerator to a proxied version of the dependency. This action improves the efficiency of the code, as the proxy class allows lazy loading (an enhanced way of loading resources), which could potentially speed up processes and reduce memory consumption.

@peterjaap
Copy link
Collaborator

Thanks!

released; https://github.com/elgentos/magento2-regenerate-catalog-urls/releases/tag/0.3.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emulation dependency injected in the console commands through DI, tries to connect to database
2 participants