CheckView: make warning items screen reader accessible #885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danirabbit
changed the title
leonardo-lemos
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when the view was entered, the screen reader would read all of the descriptions of warning items, but sometimes skip their titles.
In this branch, the screen reader instead will announce a list of n items and read the first item (with its title and description). Then you can navigate to each item at your own pace or re-read items individually
Visually there should be no significant difference between this branch and main, but
focus-visiblestyles were added so that you can see keyboard focus when the keyboard is being used to navigateThe grid of device specs remain inaccessible. This branch does not attempt to fix it