Skip to content

Support for experimental MSC4286 to not render external payment details #4099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025

Conversation

hughns
Copy link
Member

@hughns hughns commented May 7, 2025

Implementation of MSC4286

Two parts to it:

  • upgrade of matrix-rust-sdk so that the new span attribute is not stripped at that layer
  • detect the new attribute and exclude the whole span from the rendering

Depends on matrix-org/matrix-rust-sdk#5101 which was in https://github.com/element-hq/matrix-rust-components-swift/releases/tag/25.05.27 and is landed via #4151

Before After
Screenshot 2025-05-28 at 16 36 57 Screenshot 2025-05-28 at 16 27 28

In the above example the formatted_body of the event looks like this:

Thanks for subscribing!<span data-msc4286-external-payment-details> You can manage your subscription and view your payment history <a href="https://account.example.com/account/plan">here</a> at any time</span>

Pull Request Checklist

UI changes have been tested with:

  • iPhone and iPad simulators in portrait and landscape orientations.
  • Dark mode enabled and disabled.
  • Various sizes of dynamic type.
  • Voiceover enabled.

@hughns hughns added the pr-feature for a new feature label May 7, 2025
@hughns hughns force-pushed the msc4286 branch 2 times, most recently from f0e187f to 4536a80 Compare May 28, 2025 15:02
@hughns hughns marked this pull request as ready for review May 28, 2025 15:37
@hughns hughns requested a review from a team as a code owner May 28, 2025 15:37
@hughns hughns requested review from Velin92 and removed request for a team May 28, 2025 15:37
Copy link

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems reasonable to me, thanks for the test.

@pixlwave pixlwave merged commit 0f518d3 into element-hq:develop Jun 3, 2025
7 checks passed
@hughns hughns deleted the msc4286 branch June 6, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants