Skip to content

Iterate on FloatingActionButton shape and colors. #5033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 17, 2025
Merged

Iterate on FloatingActionButton shape and colors. #5033

merged 6 commits into from
Jul 17, 2025

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Jul 15, 2025 •
edited
Loading

Content

Update the Floating action button shape and colors to create a room in the room list.

For location sharing, follow design at https://www.figma.com/design/0MMNu7cTOzLOlWb7ctTkv3/Element-X?node-id=3426-141111 and improve accessibility.

Motivation and context

https://www.figma.com/design/G1xy0HDZKJf5TCRFmKb5d5/Compound-Android-Components?node-id=2029-957
https://www.figma.com/design/0MMNu7cTOzLOlWb7ctTkv3/Element-X?node-id=3426-141111

Screenshots / GIFs

Main changes:

image image

Tests

  • Launch the app
  • navigate to the room list
  • observe the new FAB shape and color
  • share a location
  • observe the new FAB shape and color

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty added the PR-Misc For other changes label Jul 15, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 15, 2025 •
edited
Loading

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/ySdzRD

@bmarty bmarty force-pushed the feature/bma/updateFabStyle branch from 2172e4f to cdbadb5 Compare July 16, 2025 08:13
@bmarty bmarty added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Jul 16, 2025
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Jul 16, 2025
@codecov Codecov
Copy link

codecov bot commented Jul 16, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.42857% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.17%. Comparing base (01fafe5) to head (cb725b2).
Report is 9 commits behind head on develop.

Files with missing lines Patch % Lines
...ion/impl/common/ui/LocationFloatingActionButton.kt 94.44% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #5033   +/-   ##
========================================
  Coverage    80.17%   80.17%           
========================================
  Files         2192     2193    +1     
  Lines        59958    59969   +11     
  Branches      7535     7535           
========================================
+ Hits         48074    48083    +9     
  Misses        9139     9139           
- Partials      2745     2747    +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bmarty bmarty marked this pull request as ready for review July 16, 2025 14:00
@bmarty bmarty requested a review from a team as a code owner July 16, 2025 14:00
@bmarty bmarty requested review from ganfra and removed request for a team July 16, 2025 14:00
ganfra
ganfra approved these changes Jul 17, 2025
View reviewed changes
Copy link
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo, otherwise LGTM, thanks!

...n/kotlin/io/element/android/features/location/impl/common/ui/LocationFloatingActionButton.kt Outdated
contentColor = ElementTheme.colors.iconPrimary,
onClick = onClick,
modifier = modifier
// Note: design is 40do, but min is 48 for accessibility.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: do => dp

@bmarty bmarty merged commit fe8b685 into develop Jul 17, 2025
24 checks passed
@bmarty bmarty deleted the feature/bma/updateFabStyle branch July 17, 2025 13:15
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ganfra ganfra ganfra approved these changes

Assignees
No one assigned
Labels
PR-Misc For other changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bmarty @ganfra @ElementBot