[a11y] Improve session verification screens #5017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5017 +/- ##
========================================
Coverage 80.24% 80.25%
========================================
Files 2191 2190 -1
Lines 59892 59895 +3
Branches 7524 7528 +4
========================================
+ Hits 48061 48066 +5
Misses 9086 9086
+ Partials 2745 2743 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bmarty
changed the title
ganfra
approved these changes
Jul 17, 2025
| @@ -36,5 +36,9 @@ data class IncomingVerificationState( | |||
| data object Canceled : Step | |||
| data object Completed : Step | |||
| data object Failure : Step | |||
|
|
|||
| val isTimeLimited: Boolean | |||
There was a problem hiding this comment.
Use a computed property instead?
There was a problem hiding this comment.
cannot work in an interface :)
| @@ -29,5 +29,11 @@ data class OutgoingVerificationState( | |||
| data class Verifying(val data: SessionVerificationData, val state: AsyncData<Unit>) : Step | |||
| data object Completed : Step | |||
| data object Exit : Step | |||
|
|
|||
| val isTimeLimited: Boolean | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
Improve session verification screen regarding accessibility.
Also remove PageTitle as it has become a duplicate of IconTitleSubtitleMolecule.
Motivation and context
Better accessibility
Closes https://github.com/element-hq/customer-success/issues/588
Screenshots / GIFs
Tests
Observe that the a11y experience is better.
Tested devices
Checklist