Skip to content

Try a workaround for the unstable call state in Maestro #4942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

jmartinesp
Copy link
Member

Content

Attempt to work around the issues we have with Maestro at the moment, so we can always tap on the start/join call button.

This seems to work, but then it seems like there is some issue with hanging up?

Motivation and context

Fix the broken Maestro tests.

Tests

Maestro should pass, or at least advance more.

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@jmartinesp jmartinesp added the PR-Build For changes related to build, tools, CI/CD label Jun 26, 2025
Copy link
Contributor

github-actions bot commented Jun 26, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/N28DCY

Copy link

codecov bot commented Jun 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.24%. Comparing base (7d3f4cb) to head (c11e16f).
Report is 13 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4942   +/-   ##
========================================
  Coverage    80.24%   80.24%           
========================================
  Files         2167     2167           
  Lines        57537    57537           
  Branches      7225     7225           
========================================
  Hits         46171    46171           
  Misses        8913     8913           
  Partials      2453     2453           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jmartinesp
Copy link
Member Author

Weird, from what I can see in the recordings the hang up button is clicked in the webview, but then nothing happens.

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Build For changes related to build, tools, CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant