Display error dialog if Element Call can't be joined #4919
+22
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When on room call type, we listen for the 'join' action for 10s, and if we don't receive one we display an error dialog which will close the call screen.
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4919 +/- ##
========================================
Coverage 80.30% 80.30%
========================================
Files 2156 2156
Lines 57373 57375 +2
Branches 7225 7225
========================================
+ Hits 46074 46076 +2
Misses 8851 8851
Partials 2448 2448 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jmartinesp
commented
Jun 23, 2025
Comment on lines
-148
to
-153
| } else if (parsedMessage.action == WidgetMessage.Action.SendEvent) { | ||
| // This event is received when a member joins the call, the first one will be the current one | ||
| val type = parsedMessage.data?.jsonObject?.get("type")?.jsonPrimitive?.contentOrNull | ||
| if (type == "org.matrix.msc3401.call.member") { | ||
| isJoinedCall = true | ||
| } |
There was a problem hiding this comment.
According to the VOIP team, this should work the same. I didn't see any changes in behaviour when I tested it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
When on room call type, we listen for the 'join' action for 10s, and if we don't receive one we display an error dialog which will close the call screen.
Motivation and context
This will allow us to remove the top app bar in a following PR.
Tests
It's kind of difficult to test unless you add an artificial delay before receiving the join action when joining a call, but maybe it's possible by using an unstable network connection. In my case I just added the delay.
Tested devices
Checklist