Skip to content

Add ability to zoom on video. #4916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025
Merged

Add ability to zoom on video. #4916

merged 1 commit into from
Jun 23, 2025

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Jun 23, 2025

Content

Use the zoomable state to apply it to the video view. Limit the zoomable/moveable area to the area of the video using setContentLocation.

Motivation and context

Improve UX on video playback and closes #2972

Screenshots / GIFs

Tests

  • Open a video sent to a room
  • Pinch to zoom the video
  • Tap and move finger to move the video
  • Other interactions (swipe vertically to dismiss/swipe horizontally to navigate through media item/click to reveal/hide overaly) should still work as previously.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner June 23, 2025 10:47
@bmarty bmarty added the PR-Change For updates to an existing feature label Jun 23, 2025
@bmarty bmarty requested review from jmartinesp and removed request for a team June 23, 2025 10:47
Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works really well, thank you!

Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/NTMibW

Copy link

Copy link

codecov bot commented Jun 23, 2025

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 80.29%. Comparing base (c838a79) to head (bece4a0).
Report is 13 commits behind head on develop.

Files with missing lines Patch % Lines
...ies/mediaviewer/impl/local/video/MediaVideoView.kt 0.00% 15 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4916      +/-   ##
===========================================
- Coverage    80.30%   80.29%   -0.01%     
===========================================
  Files         2155     2155              
  Lines        57331    57337       +6     
  Branches      7221     7221              
===========================================
  Hits         46041    46041              
- Misses        8841     8847       +6     
  Partials      2449     2449              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bmarty bmarty merged commit ae96bc6 into develop Jun 23, 2025
33 of 36 checks passed
@bmarty bmarty deleted the feature/bma/zoomVideo2 branch June 23, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Change For updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pinch and Zoom support for videos
2 participants